Added PHY drivers to CPP#6
Conversation
pradyunnkale
force-pushed
the
feature/phy_cpp_driver
branch
from
fe8bda9 to
c8144c6
Compare
CBL17
left a comment
CBL17
left a comment
There was a problem hiding this comment.
This needs to build before I continue reviewing it.
…cific folders based on the environment running using CMake
CBL17
left a comment
CBL17
left a comment
There was a problem hiding this comment.
Please close out the threads once you take care of the issues.
0xMihir
left a comment
0xMihir
left a comment
There was a problem hiding this comment.
I think we should first test this driver with the real chip on the Nucleo board before creating the sim library. This way, we can understand the actual functionality of the device before testing.
| target_link_libraries(${name} stm_hal cmsis) | ||
| endfunction() | ||
|
|
||
| if(NOT "${TARGET}" STREQUAL NATIVE) |
There was a problem hiding this comment.
We should test this driver with the actual chip before writing tests, since we need some source of truth.
| #include "phy.h" | ||
|
|
||
|
|
||
| PHY_Base_Driver::ErrorCodes PHY_SIM_Driver::init(void) { |
There was a problem hiding this comment.
Echoing my previous comment, we need to have a source of truth for these methods. We can't just have an empty method returning OK, since we need to know if our implementation is correct.
…head_flight_sw added the include in the cmakelists.txt
3 participants
No description provided.