CI: fail ci-local.sh when LLVM present but JIT compliance 100% skipped#255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@group llvmPHPUnit stage,script/ci-local.shwrites JUnit XML and runsscript/check-jit-compliance-ran.php.libLLVM-9.so.1exists but allJITTestcases were skipped (PHPUnit still reports exit 0 for “OK, but incomplete”).PHP_COMPILER_ALLOW_JIT_SKIP=1override in README.docs/bootstrap-inventory.md(stale vs current tree; required forbootstrap-inventory.php --checkin Docker CI).Closes #250. Related: #98 (root JIT loader fix), #245 (CI matrix doc).
Test plan
php-compiler:22.04-dev):check-jit-compliance-ran.phpreports “167 of 167 JIT tests executed”.LD_LIBRARY_PATH=/nonexistent: guard exits 1 with actionable message; PHPUnit exit 0 with 167 skipped.PHP_COMPILER_ALLOW_JIT_SKIP=1skips the guard (documented)../script/docker-ci-local.shbootstrap + llvm guard path exercised via tar fallback (harness bind-mount empty).Made with Cursor