Skip to content

Testing: Close #244 when ExampleWebAotTest matches RuntimeSuperglobalRefreshTest #260

@PurHur

Description

@PurHur

Problem

#244 asked for a dual-QUERY_STRING AOT regression. test/aot/RuntimeSuperglobalRefreshTest::testTwoRequestsDifferentQueryString already implements this for examples/001-SimpleWeb, but test/aot/ExampleWebAotTest.php still compiles with -q name=Example and runs once — giving a false impression that runtime refresh is untested in the "examples" path.

Goal

Single story for contributors:

  1. ExampleWebAotTest compiles without -q when LLVM present
  2. Runs binary twice with different QUERY_STRING; asserts distinct output
  3. AOT: PHPUnit dual QUERY_STRING on one compiled binary (no recompile) #244 can close; docs point to RuntimeSuperglobalRefreshTest as canonical if tests merge

Tasks

Acceptance criteria

./script/ci-local.sh --filter ExampleWebAotTest passes in php-compiler:22.04-dev without baking query at compile time.

Verification (local only)

docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \
  ./script/ci-local.sh --filter 'ExampleWebAot|RuntimeSuperglobal'

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions