You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#244 asked for a dual-QUERY_STRING AOT regression. test/aot/RuntimeSuperglobalRefreshTest::testTwoRequestsDifferentQueryString already implements this for examples/001-SimpleWeb, but test/aot/ExampleWebAotTest.php still compiles with -q name=Example and runs once — giving a false impression that runtime refresh is untested in the "examples" path.
Goal
Single story for contributors:
ExampleWebAotTest compiles without-q when LLVM present
Runs binary twice with different QUERY_STRING; asserts distinct output
Problem
#244 asked for a dual-
QUERY_STRINGAOT regression.test/aot/RuntimeSuperglobalRefreshTest::testTwoRequestsDifferentQueryStringalready implements this forexamples/001-SimpleWeb, buttest/aot/ExampleWebAotTest.phpstill compiles with-q name=Exampleand runs once — giving a false impression that runtime refresh is untested in the "examples" path.Goal
Single story for contributors:
ExampleWebAotTestcompiles without-qwhen LLVM presentQUERY_STRING; asserts distinct outputRuntimeSuperglobalRefreshTestas canonical if tests mergeTasks
ExampleWebAotTestto drop compile-time-qor add second assertion passRuntimeSuperglobalRefreshTest(shared helper trait or data provider)Acceptance criteria
./script/ci-local.sh --filter ExampleWebAotTestpasses inphp-compiler:22.04-devwithout baking query at compile time.Verification (local only)
Related