Skip to content

Fix Liminal Coil counting Marks as Curses #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Jul 12, 2026
+13 −1
Merged

Fix Liminal Coil counting Marks as Curses #2365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab692ce
Filter CurseOnEnemy multiplier to only contain curses
vaisest Jul 11, 2026
8b55833
Add test
Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions spec/System/TestItemMods_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,12 @@ describe("TetsItemMods", function()
-- more curse more dmg
assert.are_not.equals(afterEleWeaknessPhys, afterEnfeeblePhys)
assert.are_not.equals(afterEleWeaknessChaos, afterEnfeebleChaos)

build.skillsTab:PasteSocketGroup("Freezing Mark 20/0 1")
runCallback("OnFrame")
-- marks are not curses and should not grant more damage
assert.are.equals(afterEnfeeblePhys, round(build.calcsTab.mainOutput.PhysicalStoredCombinedAvg))
assert.are.equals(afterEnfeebleChaos, round(build.calcsTab.mainOutput.ChaosStoredCombinedAvg))
end)

it("twisted empyrean", function()
Expand Down
8 changes: 7 additions & 1 deletion src/Modules/CalcPerform.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3089,7 +3089,13 @@ function calcs.perform(env, skipEHP)
for _, modList in pairs(debuffs) do
enemyDB:AddList(modList)
end
modDB.multipliers["CurseOnEnemy"] = #curseSlots
local cursesInCurseSlots = {}
for _, slot in ipairs(curseSlots) do
if not slot.isMark then
table.insert(cursesInCurseSlots, slot)
end
end
modDB.multipliers["CurseOnEnemy"] = #cursesInCurseSlots
for _, slot in ipairs(curseSlots) do
enemyDB.conditions["Cursed"] = true
if slot.isMark then
Expand Down
Loading