Fix Liminal Coil counting marks#2365
Open
vaisest wants to merge 1 commit into
Open
Conversation
vaisest
force-pushed
the
fix-liminal-coil
branch
from
9df04f3 to
ab692ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2351.
Description of the problem being solved:
It seems that curse and mark slots were concatenated, which resulted in later code counting marks as curses. This PR filters those slots based on the isMark variable.
This feels like more of a workaround, and the real solution would be to completely separate marks and curses, as unlike PoE1 they are completely separate from one another.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe2/pob/2515b
Before screenshot:
After screenshot: