Skip to content

Add missing resources and fix bugs#2

Open
gerbal wants to merge 27 commits intoPandaScore:masterfrom
sevenmind:update-resources
Open

Add missing resources and fix bugs#2
gerbal wants to merge 27 commits intoPandaScore:masterfrom
sevenmind:update-resources

Conversation

@gerbal
Copy link
Copy Markdown

@gerbal gerbal commented Jan 12, 2022

This PR has the cumulative changes we have made to this library to support missing resource types and fix some unexpected behavior, specifically the formatting of nested queries is not handled correctly.

In summary the changes in this PR are:

  • run mix format
  • add ex_check (and thereby Credo)
  • add resources:
    • Coupon
    • CouponSet
    • CouponCode
    • Item
    • ItemPrice
    • PaymentIntent
    • PaymentSource
  • add basic documentation of all modules
  • refactor Resource for readability, use pipe chains for cleaner code
  • fix formatting of nested parameters to exactly match Chargebee's official library behavior.

@gerbal gerbal force-pushed the update-resources branch from 5b76416 to 18d2300 Compare April 20, 2022 15:50
@gerbal
Copy link
Copy Markdown
Author

gerbal commented Nov 18, 2022

@NicolasMarlier any interest in merging this or should I fork my own hex package?

@ringofhealth
Copy link
Copy Markdown

I think its better if you fork this and build your own hex. This is a huge improvement on the existing repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants