Add missing resources and fix bugs#2
Open
gerbal wants to merge 27 commits intoPandaScore:masterfrom
Open
Conversation
8dc5161 to
695c850
Compare
5b76416 to
18d2300
Compare
Author
|
@NicolasMarlier any interest in merging this or should I fork my own hex package? |
|
I think its better if you fork this and build your own hex. This is a huge improvement on the existing repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the cumulative changes we have made to this library to support missing resource types and fix some unexpected behavior, specifically the formatting of nested queries is not handled correctly.
In summary the changes in this PR are:
mix formatResourcefor readability, use pipe chains for cleaner code