v0.4.0 - Refactor resource definitions and add missing resources#2
Merged
v0.4.0 - Refactor resource definitions and add missing resources#2
Conversation
sascha-wolf
approved these changes
Nov 22, 2023
sascha-wolf
left a comment
sascha-wolf
left a comment
There was a problem hiding this comment.
I'm gonna be honest. I glossed over this. If you want a more thorough review I feel I need an intro.
Are we planning on merging this upstream?
Author
|
I'm happy to upstream this, though I've had PR open for 1 year to bring in some smaller changes. This package is already published on hex.pm |
gerbal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors resource method declaration into the resource use macro. Almost all endpoints have relatively generic behavior that is simple to generalize.
Changes: