Skip to content

fix: add accessible names to settings dialog controls for screen readers #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Orinks wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: add accessible names to settings dialog controls for screen readers #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/accessiclock/ui/dialogs/settings_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def _create_voice_tab(self, parent: wx.Notebook) -> wx.Panel:
voices = ["(Default system voice)"]

self.voice_choice = wx.Choice(panel, choices=voices)
self.voice_choice.SetName("Voice selection")
self.voice_choice.SetSelection(0)
sizer.Add(self.voice_choice, 0, wx.EXPAND | wx.ALL, 10)

Expand All @@ -172,7 +173,8 @@ def _create_voice_tab(self, parent: wx.Notebook) -> wx.Panel:

self.rate_slider = wx.Slider(
panel, value=150, minValue=50, maxValue=300,
style=wx.SL_HORIZONTAL | wx.SL_VALUE_LABEL
style=wx.SL_HORIZONTAL | wx.SL_VALUE_LABEL,
name="Speech rate",
)
rate_sizer.Add(self.rate_slider, 1, wx.EXPAND)
sizer.Add(rate_sizer, 0, wx.EXPAND | wx.ALL, 10)
Expand Down Expand Up @@ -226,6 +228,7 @@ def _create_quiet_hours_tab(self, parent: wx.Notebook) -> wx.Panel:
self.quiet_start_hour = wx.SpinCtrl(
panel, min=0, max=23, initial=22, size=(60, -1)
)
self.quiet_start_hour.SetName("Quiet hours start hour")
start_sizer.Add(self.quiet_start_hour, 0, wx.RIGHT, 5)

start_colon = wx.StaticText(panel, label=":")
Expand All @@ -234,6 +237,7 @@ def _create_quiet_hours_tab(self, parent: wx.Notebook) -> wx.Panel:
self.quiet_start_min = wx.SpinCtrl(
panel, min=0, max=59, initial=0, size=(60, -1)
)
self.quiet_start_min.SetName("Quiet hours start minute")
start_sizer.Add(self.quiet_start_min, 0)

time_sizer.Add(start_sizer, 0, wx.ALL, 5)
Expand All @@ -246,6 +250,7 @@ def _create_quiet_hours_tab(self, parent: wx.Notebook) -> wx.Panel:
self.quiet_end_hour = wx.SpinCtrl(
panel, min=0, max=23, initial=7, size=(60, -1)
)
self.quiet_end_hour.SetName("Quiet hours end hour")
end_sizer.Add(self.quiet_end_hour, 0, wx.RIGHT, 5)

end_colon = wx.StaticText(panel, label=":")
Expand All @@ -254,6 +259,7 @@ def _create_quiet_hours_tab(self, parent: wx.Notebook) -> wx.Panel:
self.quiet_end_min = wx.SpinCtrl(
panel, min=0, max=59, initial=0, size=(60, -1)
)
self.quiet_end_min.SetName("Quiet hours end minute")
end_sizer.Add(self.quiet_end_min, 0)

time_sizer.Add(end_sizer, 0, wx.ALL, 5)
Expand Down