Conversation
… type hierarchy Add dts.resolve for adapter-evm-core in tsup configs so .d.ts files bundle internal types alongside runtime JS. Refactor TypedPolkadotNetworkConfig to extend PolkadotNetworkConfig from ui-types directly, and TypedEvmNetworkConfig to extend EvmNetworkConfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dts.resolve: ['@openzeppelin/ui-builder-adapter-evm-core']to tsup configs for bothadapter-evmandadapter-polkadot, so type declarations (.d.ts) bundle internaladapter-evm-coretypes alongside runtime JS. This fixes exported apps failing to compile because.d.tsfiles referenced the unpublishedadapter-evm-corepackage.TypedPolkadotNetworkConfigto extendPolkadotNetworkConfigfrom@openzeppelin/ui-typesdirectly (with narrowedviemChaintyping), eliminating its type-level dependency onadapter-evm-core.TypedEvmNetworkConfigto extendEvmNetworkConfigfrom@openzeppelin/ui-typesdirectly (with narrowedviemChaintyping), instead of going throughEvmCompatibleNetworkConfig<'evm'>.Context
adapter-evm-coreis an internal workspace package bundled into the adapters via tsup'snoExternal. While the runtime JS was correctly bundled, the generated.d.tsfiles still containedimport { TypedEvmNetworkConfig } from '@openzeppelin/ui-builder-adapter-evm-core'— an unresolvable reference in exported apps sinceadapter-evm-coreis never published to npm. This causedTS2345type errors when building exported apps.The type hierarchy cleanup is an additional improvement: since
@openzeppelin/ui-typesalready definesPolkadotNetworkConfig(with all the same fields), the polkadot adapter no longer needs to extend from evm-core types at the source level. Helper types (PolkadotExecutionType,PolkadotNetworkCategory,PolkadotRelayChain) are re-exported fromui-typesfor convenience.Test plan
adapter-evm-coreimports remain in any.d.tsoutputtsctype check passes with patched.d.tsfiles