refactor(export): consolidate export testing into export-app CLI#345
Merged
refactor(export): consolidate export testing into export-app CLI#345
Conversation
Remove the unmaintained test-exported-app-local.sh script and add a new --env packed mode to the export-app CLI. The packed mode builds and packs monorepo adapter packages into tarballs, then exports an app, swaps deps with file: tarball paths, and runs pnpm install + build to verify types and bundling behave correctly post-publish. This catches .d.ts resolution issues that file: workspace links miss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/test-exported-app-local.shand consolidate its "pack and test" approach into theexport-appCLI as a new--env packedmodepnpm pack, exports an app, swaps dependencies withfile:tarball paths (+ pnpm overrides), and then runspnpm install+pnpm buildto verify types and bundling behave correctly.d.tsresolution issues (like the one fixed in fix(adapter): resolve adapter-evm-core type declarations and clean up type hierarchy #344) thatfile:workspace links miss, since tarballs simulate real npm installspnpm test:exportto use the new packed mode by defaultThree
--envmodeslocal(default)file:links to workspace dirspacked(new)pnpm packtarballsproductionTest plan
pnpm export-app export --env packedand verify it builds + packs + exports + installs + builds successfullypnpm export-app export --env packed -c polkadotfor Polkadot adapterpnpm export-app export --env packed -c stellarfor Stellar adapterpnpm export-app export(local mode, default) still workspnpm export-app export --env productionstill works