Skip to content

fix: FakeBus folds the default session like any other (drop owner-only) #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarbasAl merged 2 commits into from
Jun 29, 2026
Merged

fix: FakeBus folds the default session like any other (drop owner-only) #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9317a8d
fix: FakeBus folds the default session like any other (drop owner-only)
JarbasAl Jun 29, 2026
f11ecf1
build: require ovos-bus-client>=2.6.2a2 (consistent SessionManager re…
JarbasAl Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added ovos_logs_console_script
View file
Open in desktop
Empty file.
14 changes: 8 additions & 6 deletions ovos_utils/fakebus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,10 @@
try: # replicate side effects
from ovos_bus_client.session import Session, SessionManager
sess = Session.from_message(parsed_message)
if sess.session_id != "default":
# 'default' can only be updated by core
SessionManager.update(sess)
# every session — including the default id — folds onto the singleton
# (value-passing; nothing is owner-only, matching the spec-tools
# SessionManager and the real MessageBusClient)
SessionManager.update(sess)
except ImportError:
pass # don't care

Expand Down Expand Up @@ -273,7 +274,7 @@
# dependency, the canonical class is always present, and
# ``ovos-bus-client.Message`` is the **same** class (bus-client attaches
# ``publish`` to it too — both attachments are idempotent).
from typing import Any, Dict, Optional

Check failure on line 277 in ovos_utils/fakebus.py

View workflow job for this annotation

GitHub Actions / lint / lint

ruff (E402) 

ovos_utils/fakebus.py:277:1: E402 Module level import not at top of file

from ovos_spec_tools.message import Message as FakeMessage
from ovos_utils.log import deprecated
Expand Down Expand Up @@ -498,9 +499,10 @@
try: # replicate side effects
from ovos_bus_client.session import Session, SessionManager
sess = Session.from_message(parsed_message)
if sess.session_id != "default":
# 'default' can only be updated by core
SessionManager.update(sess)
# every session — including the default id — folds onto the singleton
# (value-passing; nothing is owner-only, matching the spec-tools
# SessionManager and the real MessageBusClient)
SessionManager.update(sess)
except ImportError:
pass # don't care

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ extras = [
"ovos-plugin-manager>=0.0.25",
"ovos-config>=0.0.12",
"ovos-workshop>=0.0.13",
"ovos_bus_client>=0.0.8",
"ovos_bus_client>=2.6.2a2",
"langcodes",
"timezonefinder",
"oauthlib~=3.2",
Expand Down
Loading