fix: FakeBus folds the default session like any other (drop owner-only)#393
Conversation
on_message no longer special-cases the default id: every session folds onto the SessionManager singleton (value-passing; nothing is owner-only), matching the spec-tools SessionManager and the real MessageBusClient.
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The automated inspectors have returned with their findings. 🕵️♂️I've aggregated the results of the automated checks for this PR below. 🔍 LintThe results are in the bag! 🎒 ❌ ruff: issues found — see job log ⚖️ License CheckChecking for any restrictive patent clauses. 📜 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔒 Security (pip-audit)I've checked for any insecure file permissions. 📂 ✅ No known vulnerabilities found (47 packages scanned). 📋 Repo HealthChecking the repo's mental health (aka developer happiness). 😊 ✅ All required files present. Latest Version: ✅ 🏷️ Release PreviewI've checked the countdown clock for the next release. ⏰ Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
📊 CoverageEnsuring our code is as robust as it looks. 💎 ✅ 85.2% total coverage Files below 80% coverage (5 files)
Full report: download the 🔨 Build TestsChecking the plumbing of your data flows. 🚰 ✅ All versions pass
A robot's work is never done... but this PR check is! ⚙️ |
…gistry) The FakeBus session integration (emit injects a session; the namespace-mirror counterpart goes through Message.forward, which now stamps the session in spec-tools >=1.2.x) needs ovos-bus-client's one-class SessionManager so emit and forward read the SAME sessions registry. Under 2.6.2a1 the registry diverged (subclass shadowing), so the original and mirrored copies carried different session bytes and the receive-side mirror dedup fingerprint mismatched (handler fired twice). 2.6.2a2 grafts onto the single registry, restoring consistency.
Part of the session-correctness work (ovos-spec-tools #67+ / ovos-bus-client #254).
FakeBus.on_message(sync + async) special-cased thedefaultid as owner-only and refused to fold it. That contradicts SESSION-1 §4 (value-passing — nothing is owner-only) and the realMessageBusClient/ spec-toolsSessionManager. Drop the guard so every session, including the default, folds onto the singleton.FakeMessageis the spec-toolsMessagere-export, soforward/replysession stamping is already inherited — no emit change needed.🤖 Generated with Claude Code