Skip to content

fix: FakeBus folds the default session like any other (drop owner-only)#393

Merged
JarbasAl merged 2 commits into
devfrom
fix/fakebus-default-folds
Jun 29, 2026
Merged

fix: FakeBus folds the default session like any other (drop owner-only)#393
JarbasAl merged 2 commits into
devfrom
fix/fakebus-default-folds

Conversation

@JarbasAl

Copy link
Copy Markdown
Member

Part of the session-correctness work (ovos-spec-tools #67+ / ovos-bus-client #254). FakeBus.on_message (sync + async) special-cased the default id as owner-only and refused to fold it. That contradicts SESSION-1 §4 (value-passing — nothing is owner-only) and the real MessageBusClient / spec-tools SessionManager. Drop the guard so every session, including the default, folds onto the singleton.

FakeMessage is the spec-tools Message re-export, so forward/reply session stamping is already inherited — no emit change needed.

🤖 Generated with Claude Code

on_message no longer special-cases the default id: every session folds onto the
SessionManager singleton (value-passing; nothing is owner-only), matching the
spec-tools SessionManager and the real MessageBusClient.
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5b733314-7496-43b8-9e46-e7bbced1f31c

📥 Commits

Reviewing files that changed from the base of the PR and between 49e9f20 and f11ecf1.

📒 Files selected for processing (3)
  • ovos_logs_console_script
  • ovos_utils/fakebus.py
  • pyproject.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fakebus-default-folds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the fix label Jun 29, 2026
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

The automated inspectors have returned with their findings. 🕵️‍♂️

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

The results are in the bag! 🎒

ruff: issues found — see job log

⚖️ License Check

Checking for any restrictive patent clauses. 📜

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔒 Security (pip-audit)

I've checked for any insecure file permissions. 📂

✅ No known vulnerabilities found (47 packages scanned).

📋 Repo Health

Checking the repo's mental health (aka developer happiness). 😊

✅ All required files present.

Latest Version: 0.13.2a1

ovos_utils/version.py — Version file
README.md — README
LICENSE — License file
pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
CHANGELOG.md — Changelog
ovos_utils/version.py has valid version block markers

🏷️ Release Preview

I've checked the countdown clock for the next release. ⏰

Current: 0.13.2a1Next: 0.13.3a1

Signal Value
Label fix
PR title fix: FakeBus folds the default session like any other (drop owner-only)
Bump build

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 0.13.3a1

Channel Status Note Current Constraint
Stable Too new (must be <0.9.0) ovos-utils>=0.8.1,<0.9.0
Testing Too new (must be <0.8.5) ovos-utils>=0.8.4,<0.8.5
Alpha Compatible ovos-utils>=0.13.2a1

📊 Coverage

Ensuring our code is as robust as it looks. 💎

85.2% total coverage

Files below 80% coverage (5 files)
File Coverage Missing lines
ovos_utils/log_parser.py 48.4% 225
ovos_utils/__init__.py 63.6% 16
ovos_utils/file_utils.py 73.3% 55
ovos_utils/thread_utils.py 76.9% 12
ovos_utils/geolocation.py 78.4% 22

Full report: download the coverage-report artifact.

🔨 Build Tests

Checking the plumbing of your data flows. 🚰

✅ All versions pass

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

A robot's work is never done... but this PR check is! ⚙️

…gistry)

The FakeBus session integration (emit injects a session; the namespace-mirror
counterpart goes through Message.forward, which now stamps the session in
spec-tools >=1.2.x) needs ovos-bus-client's one-class SessionManager so emit and
forward read the SAME sessions registry. Under 2.6.2a1 the registry diverged
(subclass shadowing), so the original and mirrored copies carried different
session bytes and the receive-side mirror dedup fingerprint mismatched (handler
fired twice). 2.6.2a2 grafts onto the single registry, restoring consistency.
@JarbasAl JarbasAl merged commit 9522042 into dev Jun 29, 2026
12 checks passed
@JarbasAl JarbasAl deleted the fix/fakebus-default-folds branch June 29, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant