Skip to content

feat: add JMS template for RabbitMQ #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kryskool wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −0
Open

feat: add JMS template for RabbitMQ #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d99d604
feat: add JMS template for RabbitMQ
kryskool Mar 10, 2026
1804b8e
fix: add missing properties when click on load button
kryskool Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions client/src/com/mirth/connect/connectors/jms/JmsConnectorPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,10 @@ private void loadTemplateButtonActionPerformed(java.awt.event.ActionEvent evt) {
connectionFactoryNameField.setText(template.getJndiConnectionFactoryName());
connectionFactoryClassField.setText(template.getConnectionFactoryClass());
connectionPropertiesTable.setProperties(template.getConnectionProperties());
usernameField.setText(template.getUsername());
passwordField.setText(template.getPassword());
clientIdField.setText(template.getClientId());
destinationNameField.setText(template.getDestinationName());
Comment on lines +646 to +649
Copy link
Member

@tonygermano tonygermano Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
usernameField.setText(template.getUsername());
passwordField.setText(template.getPassword());
clientIdField.setText(template.getClientId());
destinationNameField.setText(template.getDestinationName());

I don't think these fields were meant to be saved in a template. They are already clearly labeled in the GUI, are specific to a particular connection, and could contain sensitive data.

}
}
}//GEN-LAST:event_loadTemplateButtonActionPerformed
Expand Down
11 changes: 11 additions & 0 deletions client/src/com/mirth/connect/connectors/jms/JmsTemplateListModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,17 @@ private JmsTemplateListModel() {
properties.setJndiConnectionFactoryName("java:/ConnectionFactory");
templates.put("JBoss Messaging / MQ", properties);

properties = new JmsConnectorProperties();
properties.setUseJndi(false);
properties.setConnectionFactoryClass("com.rabbitmq.jms.admin.RMQConnectionFactory");
properties.getConnectionProperties().put("brokerURL", "failover:(tcp://localhost:5672)?maxReconnectAttempts=0");
properties.getConnectionProperties().put("closeTimeout", "15000");
properties.getConnectionProperties().put("useCompression", "no");
properties.setUsername("guest");
properties.setPassword("guest");
properties.setDestinationName("myqueue");
Comment on lines +59 to +64
Copy link
Member

@tonygermano tonygermano Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
properties.getConnectionProperties().put("brokerURL", "failover:(tcp://localhost:5672)?maxReconnectAttempts=0");
properties.getConnectionProperties().put("closeTimeout", "15000");
properties.getConnectionProperties().put("useCompression", "no");
properties.setUsername("guest");
properties.setPassword("guest");
properties.setDestinationName("myqueue");
properties.getConnectionProperties().put("host", "localhost");
properties.getConnectionProperties().put("port", "5672");
properties.getConnectionProperties().put("virtualHost", "/");

Similar to my other comment, I don't think username, password, and destinationName are meant to be saved in the template.

I believe the connection properties are not valid RabbitMQ properties. They appear to be copied from the ActiveMQ template. host, port, and virtualHost are what appear in the documentation. I tested them with non-default values and they worked. You can see what the other valid properties are by scrolling down a bit in that section.

templates.put("RabbitMQ", properties);

templateNames.addAll(templates.keySet());
readOnlyTemplateNames.addAll(templates.keySet());
}
Expand Down
Loading