feat: add JMS template for RabbitMQ#263
feat: add JMS template for RabbitMQ#263kryskool wants to merge 2 commits intoOpenIntegrationEngine:mainfrom
Conversation
Signed-off-by: Christophe Chauvet <christophe.chauvet@gmail.com>
510fa5d to
d99d604
Compare
Signed-off-by: Christophe Chauvet <christophe.chauvet@gmail.com>
tonygermano
left a comment
There was a problem hiding this comment.
I left a couple suggestions for changes.
This connector could use some work in a separate PR. It was a pain to test. It only supports jms 1.1 by default. It supports jms 2 with an additional javax.jms-api library, but not jms 3 (jakarta.jms,) and the resource dir only worked when "Load parent-first" was selected.
| usernameField.setText(template.getUsername()); | ||
| passwordField.setText(template.getPassword()); | ||
| clientIdField.setText(template.getClientId()); | ||
| destinationNameField.setText(template.getDestinationName()); |
There was a problem hiding this comment.
| usernameField.setText(template.getUsername()); | |
| passwordField.setText(template.getPassword()); | |
| clientIdField.setText(template.getClientId()); | |
| destinationNameField.setText(template.getDestinationName()); |
I don't think these fields were meant to be saved in a template. They are already clearly labeled in the GUI, are specific to a particular connection, and could contain sensitive data.
| properties.getConnectionProperties().put("brokerURL", "failover:(tcp://localhost:5672)?maxReconnectAttempts=0"); | ||
| properties.getConnectionProperties().put("closeTimeout", "15000"); | ||
| properties.getConnectionProperties().put("useCompression", "no"); | ||
| properties.setUsername("guest"); | ||
| properties.setPassword("guest"); | ||
| properties.setDestinationName("myqueue"); |
There was a problem hiding this comment.
| properties.getConnectionProperties().put("brokerURL", "failover:(tcp://localhost:5672)?maxReconnectAttempts=0"); | |
| properties.getConnectionProperties().put("closeTimeout", "15000"); | |
| properties.getConnectionProperties().put("useCompression", "no"); | |
| properties.setUsername("guest"); | |
| properties.setPassword("guest"); | |
| properties.setDestinationName("myqueue"); | |
| properties.getConnectionProperties().put("host", "localhost"); | |
| properties.getConnectionProperties().put("port", "5672"); | |
| properties.getConnectionProperties().put("virtualHost", "/"); |
Similar to my other comment, I don't think username, password, and destinationName are meant to be saved in the template.
I believe the connection properties are not valid RabbitMQ properties. They appear to be copied from the ActiveMQ template. host, port, and virtualHost are what appear in the documentation. I tested them with non-default values and they worked. You can see what the other valid properties are by scrolling down a bit in that section.
Add template for JMS connection with RabbitMQ