Fix StrategyResult.resolve() mutating internal weights

src/stratocaster/base/strategy.py

@@ -33,7 +33,7 @@ def weights(self) -> dict[GufeKey, float | None]:
 
     def resolve(self) -> dict[GufeKey, float | None]:
         """Normalize the proposal weights relative to all non-None Transformation weights."""
-        weights = self.weights
+        weights = dict(self.weights)
         weight_sum = sum([weight for weight in weights.values() if weight is not None])
         modified_weights = {
             key: weight / weight_sum

src/stratocaster/tests/test_strategy_base.py

@@ -17,6 +17,16 @@ class TestStrategyResult:
     def test_dict_roundtrip(self):
         assert StrategyResult.from_dict(self.result.to_dict()) == self.result
 
+    def test_resolve_does_not_mutate_weights(self):
+        original_weights = dict(self.result.weights)
+        self.result.resolve()
+        assert self.result.weights == original_weights
+
+    def test_resolve_is_idempotent(self):
+        first = self.result.resolve()
+        second = self.result.resolve()
+        assert first == second
+
 
 class DummyStrategySettings(StrategySettings):
     pass