Fix StrategyResult.resolve() mutating internal weights#18
Closed
Fix StrategyResult.resolve() mutating internal weights#18
Conversation
resolve() operated on self.weights directly (a reference to self._weights), so calling it would normalize the internal dict in-place. Subsequent calls would double-normalize, producing incorrect results. Copy the dict first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
To clarify, Regardless closing in favor of #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve()referencedself._weightsdirectly, so each call normalized the dict in-place. A second call would double-normalize, producing wrong results.Test plan
test_resolve_does_not_mutate_weights— verifiesweightsunchanged afterresolve()test_resolve_is_idempotent— verifies two consecutiveresolve()calls return the same result🤖 Generated with Claude Code