Skip to content

fix: better run follow up issues#4737

Open
doc-han wants to merge 5 commits into
mainfrom
4736-fix-better-run-follow-issues
Open

fix: better run follow up issues#4737
doc-han wants to merge 5 commits into
mainfrom
4736-fix-better-run-follow-issues

Conversation

@doc-han
Copy link
Copy Markdown
Contributor

@doc-han doc-han commented May 11, 2026

Description

This PR currently fixes several issues around Better Run Experience

  1. Ctrl + Enter now calls the primary action "Run" instead of the secondary action "Run with cutom inplut".
  2. Making the primary action when a run is loaded to be "Retry" instead of "Create new workorder".

Closes #4736

Validation steps

  1. (How can a reviewer validate your work?)

Additional notes for the reviewer

  1. (Is there anything else the reviewer should know or look out for?)

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@doc-han doc-han linked an issue May 11, 2026 that may be closed by this pull request
2 tasks
@github-project-automation github-project-automation Bot moved this to New Issues in Core May 11, 2026
@github-actions
Copy link
Copy Markdown

The PR is purely frontend: it moves a Ctrl/Cmd+Enter keyboard shortcut from WorkflowEditor.tsx into Header.tsx and reuses the existing handleRunClick callback (already gated by canRun and other UI conditions). No backend, query, policy, or audit-trail changes.

Security Review ✅

  • S0 (project scoping): N/A — pure React/TSX change, no new queries or web-layer entrypoints touching project-scoped data.
  • S1 (authorization): N/A — no new handle_event/controller actions; the shortcut just invokes the existing handleRunClick already governed by useCanRun() and server-side checks.
  • S2 (audit trail): N/A — no writes to config resources, no Ecto.Multi changes.

@doc-han doc-han changed the title fix: better run experience issues fix: keyboard shortcut for run primary action (Better runs) May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.88%. Comparing base (08ba6e1) to head (9faf21d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4737      +/-   ##
==========================================
- Coverage   89.96%   89.88%   -0.09%     
==========================================
  Files         444      444              
  Lines       21979    21979              
==========================================
- Hits        19773    19755      -18     
- Misses       2206     2224      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@doc-han doc-han changed the title fix: keyboard shortcut for run primary action (Better runs) fix: better run follow up issues May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

Fix better run follow issues

1 participant