Add methods for registers Get Discovered SVIDs, Received SOP/SOP' Identity Data, executing Hard Reset#104
Merged
RobertZ2011 merged 23 commits intoApr 29, 2026
Conversation
These allow callers to handle non-compliant devices, particularly DRDs that don't send a DFP VDO.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for reading/parsing additional TPS6699x registers related to USB PD discovery/identity, and exposes a new hard reset command through the async (Embassy) API.
Changes:
- Add register wrappers for Discovered SVIDs (0x21) and Received SOP/SOP’ Identity Data Objects (0x48/0x49), including conversion into
embedded_usb_pdresponse types. - Add async methods to read the new registers, plus an Embassy wrapper method to execute the new Hard Reset command.
- Update
embedded-usb-pdgit revision and aligngcdm’sSvidimport with the structured VDM type.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| src/registers/discovered_svids.rs | New register wrapper + iterators (and tests) for discovered SVIDs (0x21). |
| src/registers/received_sop_identity_data.rs | New register wrapper + parsing/conversion for SOP Discover Identity response (0x48). |
| src/registers/received_sop_prime_identity_data.rs | New register wrapper + parsing/conversion for SOP’ Discover Identity response (0x49). |
| src/registers/mod.rs | Exposes the new register modules. |
| src/asynchronous/internal/mod.rs | Adds async read helpers for the new large registers. |
| src/asynchronous/embassy/mod.rs | Adds Embassy API wrappers for reading new registers and executing HRST. |
| src/command/mod.rs | Adds HRST command and updates command decoding tests. |
| src/command/gcdm.rs | Switches Svid import to vdm::structured::Svid. |
| Cargo.lock | Bumps embedded-usb-pd git revision. |
Co-authored-by: Copilot <copilot@github.com>
RobertZ2011
requested changes
Apr 28, 2026
kurtjd
approved these changes
Apr 29, 2026
RobertZ2011
approved these changes
Apr 29, 2026
jerrysxie
pushed a commit
to jerrysxie/tps6699x
that referenced
this pull request
May 4, 2026
…ntity Data, executing Hard Reset (OpenDevicePartnership#104) Builds on OpenDevicePartnership/embedded-usb-pd#64 --------- Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on OpenDevicePartnership/embedded-usb-pd#64