Skip to content

Add port commands for getting Discovered SVIDs, Discover Identity, executing Hard Reset#820

Merged
asasine merged 12 commits into
OpenDevicePartnership:mainfrom
asasine:discovered-svids
May 4, 2026
Merged

Add port commands for getting Discovered SVIDs, Discover Identity, executing Hard Reset#820
asasine merged 12 commits into
OpenDevicePartnership:mainfrom
asasine:discovered-svids

Conversation

Copilot AI review requested due to automatic review settings April 29, 2026 21:09
@asasine asasine requested review from a team as code owners April 29, 2026 21:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

Cargo Vet Audit Passed

cargo vet has passed in this PR. No new unvetted dependencies were found.

@github-actions github-actions Bot added the cargo vet PRs pending auditor review label Apr 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new Type‑C/USB‑PD port commands to expose discovered SVIDs, retrieve cached Discover Identity responses (SOP/SOP′), and trigger a Hard Reset through the embedded-services Type‑C controller abstraction and the type-c-service wrapper/driver layers.

Changes:

  • Extend the Type‑C controller/external command enums and context APIs with GetDiscoveredSvids, GetDiscoverIdentity* (SOP/SOP′), and HardReset.
  • Implement these new controller APIs for the TPS6699x driver and the std mock controller.
  • Wire the new external commands through the type-c-service port command handler and PD wrapper.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
type-c-service/src/wrapper/pd.rs Routes new PortCommandData variants to controller driver calls and returns new PortResponseData variants.
type-c-service/src/service/port.rs Adds service-level handlers for the new external port commands.
type-c-service/src/driver/tps6699x.rs Implements controller trait methods for discovered SVIDs, hard reset, and Discover Identity response retrieval.
examples/std/src/lib/type_c/mock_controller.rs Extends the mock controller to satisfy the updated Controller trait.
embedded-service/src/type_c/external.rs Adds new external command/response variants and helper functions for the new APIs.
embedded-service/src/type_c/controller.rs Adds DiscoveredSvids type, new controller trait methods, lookup helper, and ContextToken APIs.
Cargo.lock Updates lockfile for dependency revisions (notably embedded-usb-pd and tps6699x).

Comment thread type-c-service/src/service/port.rs Outdated
Comment thread type-c-service/src/service/port.rs Outdated
Comment thread embedded-service/src/type_c/controller.rs Outdated
Comment thread embedded-service/src/type_c/controller.rs Outdated
Comment thread embedded-service/src/type_c/controller.rs Outdated
@asasine asasine requested a review from a team as a code owner April 29, 2026 21:21
Comment thread embedded-service/src/type_c/controller.rs Outdated
@asasine asasine enabled auto-merge (squash) May 4, 2026 20:57
@asasine asasine merged commit 5848b67 into OpenDevicePartnership:main May 4, 2026
15 checks passed
@asasine asasine deleted the discovered-svids branch May 4, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cargo vet PRs pending auditor review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants