Update embedded-services + hals#16
Conversation
9a85894 to
38d6ff4
Compare
Cargo Vet Audit Failed
If the unvetted dependencies are not neededPlease modify Cargo.toml file to avoid including the dependencies. If the unvetted dependencies are neededPost a new comment with the questionnaire below to the PR to help the auditors vet the dependencies. Copy and paste the questionnaire as a new comment and provide your answers:1. What crates (with version) need to be audited? 2. How many of the crates are version updates vs new dependencies? 3. To confirm none of the already included crates serve your needs, please provide a brief description of the purpose of the new crates. 4. Any extra notes to the auditors to help with their audits. |
There was a problem hiding this comment.
Pull request overview
This PR updates the firmware’s OpenDevicePartnership embedded-services dependency set (including uart-service moving to embedded-io-async v0.7) and aligns platform HAL usage to remove now-unnecessary UART adapter/wrapper layers.
Changes:
- Bump
platform-commonto explicitly includeembedded-io/embedded-io-asyncv0.7 to match the updated service stack. - Update
dev-npcxanddev-mcxato pass HAL UART instances directly intouart-servicetasks (removing wrapper/adapter code). - Refresh per-platform lockfiles to the new
embedded-services+ HAL revisions.
Reviewed changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| platform/platform-common/Cargo.toml | Adds embedded-io/embedded-io-async v0.7 dependencies to align with updated services. |
| platform/platform-common/Cargo.lock | Lockfile refresh for updated embedded-services revision and dependency graph. |
| platform/dev-qemu/Cargo.lock | Lockfile refresh for updated embedded-services + embassy-qemu-riscv revision and embedded-io(-async) v0.7. |
| platform/dev-npcx/src/main.rs | Updates UART task signature to accept the HAL UART directly (no wrapper). |
| platform/dev-npcx/src/board.rs | Removes UART wrapper and exposes uart::Uart directly from the board. |
| platform/dev-npcx/Cargo.lock | Lockfile refresh reflecting updated dependencies (still shows embedded-io-async v0.6 pulled in). |
| platform/dev-mcxa/src/uart_adapter.rs | Deletes the v0.6 compatibility adapter (no longer needed with v0.7 services). |
| platform/dev-mcxa/src/main.rs | Updates UART task to use lpuart::LpuartBbq directly and removes adapter usage. |
| platform/dev-mcxa/Cargo.toml | Updates embassy-mcxa revision and removes explicit v0.6 embedded-io(-async) compatibility deps. |
| platform/dev-mcxa/Cargo.lock | Lockfile refresh for updated embassy revision + service stack changes. |
| platform/dev-imxrt/meta_err.txt | Adds/keeps an empty file in the repo (appears to be an artifact). |
| platform/dev-imxrt/Cargo.lock | Lockfile refresh for updated embedded-services + embassy-imxrt revision and embedded-io(-async) v0.7 additions. |
Recently updated
uart-serviceto use v7 ofembedded-io-asyncso updateembedded-serviceshere to pull in those changes. Additionally had to make several changes to all the HALs (embassy-imxrt, embassy-mcxa, embassy-npcx, and embassy-qemu-riscv) to clean some things up (like updating those hals to impl v7 and implementing the traits for unsplit uart instances).This allows some cleanup here such as removing all the uart wrappers.