Skip to content

[PATCH v3] api: crypto: clarify output_pool session parameter and specify its default value #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatiasElo merged 3 commits into from
Dec 30, 2025
Merged

[PATCH v3] api: crypto: clarify output_pool session parameter and specify its default value #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6595af6
api: crypto: specify default value for output_pool session parameter
JannePeltonen Dec 19, 2025
18b7773
validation: crypto: test default value of output_pool parameter
JannePeltonen Dec 19, 2025
28d5a55
test: pipeline: do not set output_pool crypto session parameter
JannePeltonen Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions include/odp/api/spec/crypto_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: BSD-3-Clause
* Copyright (c) 2014-2018 Linaro Limited
* Copyright (c) 2021-2024 Nokia
* Copyright (c) 2021-2025 Nokia
*/

/**
Expand Down Expand Up @@ -920,8 +920,10 @@ typedef struct odp_crypto_session_param_t {

/** Output pool
*
* In ODP_CRYPTO_OP_TYPE_BASIC and ODP_CRYPTO_OP_TYPE_OOP
* operation types this must be set to ODP_POOL_INVALID.
* This field is unused and will be deprecated later.
* The value must be left to the default value.
*
* Default value is ODP_POOL_INVALID.
*/
odp_pool_t output_pool;

Expand Down
1 change: 0 additions & 1 deletion test/performance/pipeline/crypto_parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ static odp_bool_t parse_crypto_entry(config_setting_t *cs, crypto_parse_t *crypt
crypto->param.op_mode = ODP_CRYPTO_ASYNC;
crypto->param.cipher_key.data = NULL;
crypto->param.auth_key.data = NULL;
crypto->param.output_pool = ODP_POOL_INVALID;

if (config_setting_lookup_string(cs, CONF_STR_NAME, &val_str) == CONFIG_FALSE) {
ODPH_ERR("No \"" CONF_STR_NAME "\" found\n");
Expand Down
2 changes: 1 addition & 1 deletion test/validation/api/crypto/odp_crypto_test_inp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ static void test_defaults(uint8_t fill)
CU_ASSERT(param.auth_alg == ODP_AUTH_ALG_NULL);
CU_ASSERT(param.auth_iv_len == 0);
CU_ASSERT(param.auth_aad_len == 0);
CU_ASSERT(param.output_pool == ODP_POOL_INVALID);
}

static void test_default_values(void)
Expand Down Expand Up @@ -212,7 +213,6 @@ static int session_create(crypto_session_t *session,
ses_params.cipher_alg = ref->cipher;
ses_params.auth_alg = ref->auth;
ses_params.compl_queue = suite_context.queue;
ses_params.output_pool = ODP_POOL_INVALID;
ses_params.cipher_key = cipher_key;
ses_params.cipher_iv_len = ref->cipher_iv_length;
ses_params.auth_iv_len = ref->auth_iv_length;
Expand Down