[PATCH v3] api: crypto: clarify output_pool session parameter and specify its default value #2300
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
TuomasTaipale
approved these changes
Dec 19, 2025
Collaborator
|
Just noticed |
Collaborator
Author
It does not require changes right now since setting output_pool to ODP_POOL_INVALID (i.e. to the default value) is still ok. Setting of the output_pool should be removed from the file, but the problem is that the code is written without the odp_crypto_session_param_init() function and therefore the output_pool setting cannot be simply removed but a bit bigger change that introduces the init function call is needed. I did not want to do that as part of this API commit but left it for the future. But yes, the pool setting needs to be removed at some point. |
psavol
approved these changes
Dec 19, 2025
JannePeltonen
force-pushed
the
api-crypto-output-pool
branch
from
3b49fe3 to
7d843c1
Compare
odpbuild
changed the title
Collaborator
Author
|
v2: added review tags |
Now that the deprecated legacy crypto operation mode has been fully removed from the API, the output_pool crypto session parameter is no longer used. Change the description of the parameter to mention that the parameter is not used and will be deprecated. Specify that the parameter must be left to the default value and that the default value is ODP_POOL_INVALID. This way existing code that is setting the output_pool session parameter to ODP_POOL_INVALID continues to be valid but it becomes possible to remove the explicit setting of the parameter as preparation for its eventual deprecation. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
Test that the default value of the output_pool crypto session parameter is ODP_POOL_INVALID as now specified in the API and rely on the default value when creating sessions. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
Do not explicitly set the output_pool crypto session parameter but rely on the default value set by odp_crypto_session_param_init(). Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
JannePeltonen
force-pushed
the
api-crypto-output-pool
branch
from
7d843c1 to
28d5a55
Compare
odpbuild
changed the title
Collaborator
Author
|
v3: rebased |
MatiasElo
added
the
API Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assumes that PR 2258 "api: crypto: remove legacy operation type" has been merged.
Clarify that the output_pool crypto session parameter is unused and will be deprecated later. Specify that the parameter has default value of ODP_PACKET_INVALID and clarify that that is the only valid value for the parameter.