Skip to content

fix(auth): do not trust custom OIDC for account linking #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BunsDev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(auth): do not trust custom OIDC for account linking #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/web/src/lib/server/auth/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,9 @@ async function createAuth() {
...(creds.tokenUrl && { tokenUrl: creds.tokenUrl }),
scopes: scopeStr.split(/\s+/).filter(Boolean),
})
trustedProviders.push(provider.id)
// Do not trust arbitrary custom OIDC providers for automatic
// account linking. Built-in providers and dedicated workspace
// SSO are trusted separately.
Comment on lines +254 to +256
} else {
// Built-in social providers
const providerConfig: Record<string, string> = {
Expand Down
Loading