fix(auth): do not trust custom OIDC for account linking#49
Open
BunsDev wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Prevents admin-configured generic OAuth/OIDC providers from being treated as “trusted” for automatic account linking, reducing the risk of unintended account linkage via arbitrary custom IdPs.
Changes:
- Removes adding
provider.idtoaccountLinking.trustedProvidersforprovider.type === 'generic-oauth'. - Adds an explanatory comment clarifying why custom providers are not trusted for linking.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+254
to
+256
| // Do not trust arbitrary custom OIDC providers for automatic | ||
| // account linking. Built-in providers and dedicated workspace | ||
| // SSO are trusted separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
accountLinking.trustedProviderslist so that arbitrary custom IdPs cannot automatically link to existing user accounts.Description
provider.idintotrustedProvidersforprovider.type === 'generic-oauth'while preserving registration for sign-in and existing trust for built-in social providers and workspace SSO.Testing
git diff --checkwhich passed, and confirmed the source change withrgsearching for the removedtrustedProviders.push(provider.id)which returned the updated file location, both succeeding;bun run typecheckwas attempted but blocked by missing type definitions in this environment;bun install --frozen-lockfilewas attempted but blocked by npm registry 403 errors so full dependency installation and typechecking could not be completed.Codex Task