Skip to content

Stability: Aggressive health check causes connection flapping #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OneStepAt4time merged 1 commit into from
Apr 11, 2026
Merged

Stability: Aggressive health check causes connection flapping #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/cdp/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,11 +239,12 @@ export class CDPClient {
const result = await Promise.race([
this.evaluate('1+1'),
new Promise<never>((_, reject) =>
setTimeout(() => reject(new Error('health check timeout')), 3000),
setTimeout(() => reject(new Error('health check timeout')), 10000),
),
])
return result.result?.value === 2
} catch {
} catch (err) {
this.logger.debug(`Health check failed: ${err instanceof Error ? err.message : String(err)}`)
this.state.connected = false
return false
}
Expand Down
Loading