fix(dashboard): gate SettingsPage console.warn behind DEV mode (#4066)#4074
Merged
Merged
Conversation
localStorage warnings should not ship to production console. Gate all 3 console.warn calls behind import.meta.env.DEV check.
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Approved. Clean, minimal fix — gating console.warn behind import.meta.env.DEV is the correct Vite pattern. No behavioral change in dev, removes production noise. All CI green, targets develop, closes #4066.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Production console noise in SettingsPage
Closes #4066
Problem
3
console.warncalls ship to production in SettingsPage.tsx — localStorage load/save/clear failures.Fix
Gate all 3 behind
import.meta.env.DEVcheck. Still warns in dev, silent in production.Files
dashboard/src/pages/SettingsPage.tsx— 3 lines changedVerification
Dashboard build: ✓ clean