Code Quality
SettingsPage has 3 console.warn calls that ship to production:
File: dashboard/src/pages/SettingsPage.tsx
- Line 41:
console.warn('SettingsPage: failed to load settings from localStorage:', err);
- Line 50:
console.warn('SettingsPage: failed to save settings to localStorage:', err);
- Line 158:
console.warn('SettingsPage: failed to clear onboarding flag:', err);
Also:
TerminalPassthrough.tsx line 104: console.info (guarded by import.meta.env.DEV — OK)
Icon.tsx line 101: console.warn for unknown icons — acceptable for dev debugging
Impact: Console noise in production. Not a user-visible bug but violates the "no console.log in production" principle from SOUL.md.
Acceptance criteria:
- Replace
console.warn in SettingsPage with silent error handling or a structured logger
- Or gate behind
import.meta.env.DEV
Labels: dashboard, tech-debt
Code Quality
SettingsPage has 3
console.warncalls that ship to production:File:
dashboard/src/pages/SettingsPage.tsxconsole.warn('SettingsPage: failed to load settings from localStorage:', err);console.warn('SettingsPage: failed to save settings to localStorage:', err);console.warn('SettingsPage: failed to clear onboarding flag:', err);Also:
TerminalPassthrough.tsxline 104:console.info(guarded byimport.meta.env.DEV— OK)Icon.tsxline 101:console.warnfor unknown icons — acceptable for dev debuggingImpact: Console noise in production. Not a user-visible bug but violates the "no console.log in production" principle from SOUL.md.
Acceptance criteria:
console.warnin SettingsPage with silent error handling or a structured loggerimport.meta.env.DEVLabels: dashboard, tech-debt