libgis: G_vasprintf bug fix#3650
Open
HuidaeCho wants to merge 6 commits into
Open
Conversation
Merged
Member
|
@nilason What's your opinion on this? It was fixing a bug 6 months ago caught in the cmake PR. |
Member
|
The build errors were no longer visible, so I updated the branch again. |
Member
|
The error is Details: |
nilason
reviewed
Oct 25, 2024
| va_end(ap); | ||
|
|
||
| for (;;) { | ||
| if (count >= osize) { |
Contributor
There was a problem hiding this comment.
This addresses the warning, and take into account if the previous vsnprintf call fails.
Suggested change
| if (count >= osize) { | |
| if (count < 0) | |
| return count; | |
| if ((size_t)count >= osize) { |
Member
|
Should we update the branch first? |
Contributor
|
@HuidaeCho shall we push this for 8.5? |
Member
Author
Yes. Let's push it. |
Contributor
|
There was a compiler warning to which I had a suggestion. That warning should be addressed and let us update the branch before merge. |
Member
Author
I'll take a look into it this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a
G_vasprintfbug for#elseof#ifdef HAVE_ASPRINTF.From the man page of
vsnprintf():size *= 2becausecountis already the full length without\0if it's greater than or equal tosize.apcannot be reused in a for loop. It needs to be copied before its first use so we can use it again.