Skip to content

libgis: Rename ap_copy to aq for G_aprintf#3651

Merged
HuidaeCho merged 1 commit into
OSGeo:mainfrom
HuidaeCho:aprintf_rename_ap_copy
Apr 23, 2024
Merged

libgis: Rename ap_copy to aq for G_aprintf#3651
HuidaeCho merged 1 commit into
OSGeo:mainfrom
HuidaeCho:aprintf_rename_ap_copy

Conversation

@HuidaeCho

@HuidaeCho HuidaeCho commented Apr 23, 2024

Copy link
Copy Markdown
Member

This PR simply renames ap_copy to aq. I just like this name better from the va_copy man page ;-).

@HuidaeCho HuidaeCho added C Related code is in C libraries labels Apr 23, 2024
echoix
echoix previously approved these changes Apr 23, 2024

@echoix echoix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no mentions in docs to adjust (assuming it's in the private part of the library), shouldn't be a problem.

@echoix

echoix commented Apr 23, 2024

Copy link
Copy Markdown
Member

But what does aq mean? Is it a convention?

@HuidaeCho

Copy link
Copy Markdown
Member Author

But what does aq mean? Is it a convention?

aq next to ap just like i, j...

@echoix

echoix commented Apr 23, 2024

Copy link
Copy Markdown
Member

And ap was for the ap in aprintf ?

@echoix echoix added this to the 8.4.0 milestone Apr 23, 2024
@HuidaeCho

Copy link
Copy Markdown
Member Author

And ap was for the ap in aprintf ?

I think "argument pointer"?

@HuidaeCho HuidaeCho enabled auto-merge (squash) April 23, 2024 04:39
@echoix

echoix commented Apr 23, 2024

Copy link
Copy Markdown
Member

Maybe aq isn't as descriptive then, since it isn't just an loop variable, but had a meaning (that variable had to be copied as we saw from the vasprintf bug that #3650 would fix)

@echoix echoix dismissed their stale review April 23, 2024 04:57

I'm not sure enough now

@HuidaeCho

Copy link
Copy Markdown
Member Author

But what does aq mean? Is it a convention?

I think it became kind of a convention because it's from the man page of va_copy:

@echoix

echoix commented Apr 23, 2024

Copy link
Copy Markdown
Member

But what does aq mean? Is it a convention?

I think it became kind of a convention because it's from the man page of va_copy:

You convinced me easily!

@HuidaeCho HuidaeCho merged commit 5661bad into OSGeo:main Apr 23, 2024
@HuidaeCho HuidaeCho deleted the aprintf_rename_ap_copy branch April 23, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants