[18.0][MIG] connector_importer_product: Migration to 18.0#155
[18.0][MIG] connector_importer_product: Migration to 18.0#155OCA-git-bot merged 5 commits intoOCA:18.0from
Conversation
vvrossem
force-pushed
the
18.0-mig-connector_importer_product
branch
from
7aa4015 to
e731ea0
Compare
|
Hello @simahawk, what would you advice to do regarding the CI failing because of multiple WARNING in the logs? 🙏 |
|
silent the ones that you can in the tests (eg: the warning for debug mode). This we can even turn it off when in test mode directly (see where debug_mode is used). For the others, if any you can ignore the via https://github.com/OCA/connector-interfaces/blob/18.0/checklog-odoo.cfg |
connector_importer_product/components/product_product/record_handler.py
Outdated
Show resolved
Hide resolved
connector_importer_product/components/product_product/record_handler.py
Outdated
Show resolved
Hide resolved
|
This PR has the |
Ricardoalso
force-pushed
the
18.0-mig-connector_importer_product
branch
2 times, most recently
from
d8ca4e7 to
4f2c0bc
Compare
|
@vvrossem I just rebased this PR in order to be able to migrate this pending.merge https://github.com/OCA/connector-interfaces/pull/141/commits |
|
fwd port of #153 |
|
As I need a clear picture on the changes I've decided to add the module as not installable to v18. See #166. Can you please:
|
Ricardoalso
force-pushed
the
18.0-mig-connector_importer_product
branch
2 times, most recently
from
b7df940 to
9adde26
Compare
Early return if no product.attribute.value is to be imported
When updating product.product records, product_tmpl_id is set to False in values if not specified in the import type. But we don't want to set it to False as the value already exists in the odoo_record
Ricardoalso
force-pushed
the
18.0-mig-connector_importer_product
branch
2 times, most recently
from
9b8d6ea to
3ac220b
Compare
|
[FIX][18.0] connector_importer: take full control of what are the required_keys #162 isolated in another PR |
| - Simone Orsi \<<simahawk@gmail.com>\> | ||
| - Sébastien Alix \<<sebastien.alix@camptocamp.com>\> | ||
| - Jacques-Etienne Baudoux \<<je@bcim.be>\> | ||
| - Matthieu Méquignon \<<matthieu.mequignon@camptocamp.com>\> |
There was a problem hiding this comment.
You can add your name here ;)
|
This PR has the |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at e5720ef. Thanks a lot for contributing to OCA. ❤️ |
6 participants
Notes:
product.packaging::product_idisrequired: https://github.com/odoo/odoo/blob/17.0/addons/product/models/product_packaging.py#L20