[FIX][18.0] connector_importer_product: proposition of 'fixes' for additional flexibility#161
Closed
Ricardoalso wants to merge 48 commits intoOCA:18.0from
Closed
[FIX][18.0] connector_importer_product: proposition of 'fixes' for additional flexibility#161Ricardoalso wants to merge 48 commits intoOCA:18.0from
Ricardoalso wants to merge 48 commits intoOCA:18.0from
Conversation
The mapper now uses the dynanic mapper to automatically find and convert values from source to destination. We can trash many direct mappings! Additionally, the supplier is now imported automatically.
`prod.product_template_attribute_value_ids` must be set using _only_ valid values. To find them, we must use `_without_no_variant_attribute()` as Odoo does in relevant places. `combination_indices` depends on `product_template_attribute_value_ids`, hence if its value is wrong the index will be wrong and you won't find the right variant. Additionally, when using the product configurator, since the combination is wrong the product won't be purchase-able or sale-able w/ the configurator.
Make import type non demo only to provide a default setup.
Allows to import product and suppliers at the same time.
If xid is used as a unique identifier we must create a xid for the template too. This way you can reference it w/ 'xid::product_tmpl_id'
Early return if no product.attribute.value is to be imported
When updating product.product records, product_tmpl_id is set to False in values if not specified in the import type. But we don't want to set it to False as the value already exists in the odoo_record
Contributor
|
Hi @simahawk, |
Contributor
|
Can you please:
I can help you if needed. |
Contributor
|
Shall we close the other PR? |
Contributor
Author
Contributor
|
then why opening another PR w/ the whole stuff? 🤔 |
Contributor
Author
It was while waiting the other one getting merged. Once it is done I will rebase this one |
Ricardoalso
force-pushed
the
18_fixes_connector_importer_product
branch
from
660d817 to
16d8fae
Compare
Contributor
Author
I moved the commit related to connector_importer to #162 |
Ricardoalso
changed the title
Contributor
|
@simahawk Could you have a look at it? |
Contributor
|
can you move commits related to migration to #155 so that we can close this one? |
Contributor
|
One more thing: note that I've just merged some fix/imp on v14. You might want to fwd port #153 😉 |
Contributor
Author
|
fwd port to #153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on connector_importer_product migration #155
and porting the following fix https://github.com/OCA/connector-interfaces/pull/141/commits to V18