feat: consolidate issue 54 ingestion and promotion gates#67
Closed
steezkelly wants to merge 12 commits into
Closed
feat: consolidate issue 54 ingestion and promotion gates#67steezkelly wants to merge 12 commits into
steezkelly wants to merge 12 commits into
Conversation
This was referenced May 9, 2026
Author
|
Closing this PR in favor of consolidated PR #68. Local integration found real helper-block overlap in evolution/skills/evolve_skill.py across the stack, and #68 preserves local test evidence: targeted stack tests 41 passed; full suite 164 passed; GitHub checks were absent on the split PRs. Review #68 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the open issue #54 implementation stack and the overlapping prerequisite safety fixes from PRs #60, #61, #63, #64, #65, and #66 into one reviewable PR.
This is a consolidation PR because direct merge was unavailable to the contributor account and local integration found a real overlap between #61 and #64 in
evolution/skills/evolve_skill.py. Keeping the stack split would require maintainers to resolve that conflict manually after the first overlapping PR lands.Includes:
reportlab>=4.0and regression-test report import/install behaviorOverlap / conflict resolution
Local integration found one real conflict between #61 and #64:
ConstraintResultinevolution/skills/evolve_skill.pywrite_run_reportin the same import blockThe consolidated branch resolves this by keeping both:
No other file conflicts were found in the tested integration stack.
Local verification evidence
GitHub checks were absent on the source PRs:
statusCheckRolluplength was 0 for #60, #61, #63, #64, #65, and #66 when reviewed withgh pr view.Local evidence preserved in the working copy at:
/home/steve/repos/hermes-agent-self-evolution/issue-54-pr-stack-local-evidence.mdCommands run in a fresh local venv:
Results:
21 passed, 11 warnings in 1.33s160 passed, 11 warnings in 1.42sWarnings were DSPy dependency deprecation warnings about the
prefixargument inInputField/OutputField; no test failures.Review / merge guidance
If maintainers prefer the original split PRs instead of this consolidation PR, the tested conceptual merge order is:
Otherwise, review and merge this PR as the consolidated path, then close the split PRs as superseded.
Closes #54.
Supersedes #60, #61, #63, #64, #65, #66.