fix: declare reportlab dependency#60
Closed
steezkelly wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this split PR in favor of consolidated PR #67. Local integration found review/merge overhead across the stack (notably #61/#64 overlap in evolution/skills/evolve_skill.py), and #67 preserves the combined local test evidence: targeted stack tests 21 passed; full suite 160 passed; GitHub checks were absent on the split PRs. Review #67 instead. |
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #33 M4 by declaring the PDF report generator dependency:
reportlab>=4.0to project dependenciesreportlabis declared whengenerate_report.pyimports itgenerate_report.pyafter project installRoot cause
generate_report.pyimportsreportlabat module import time, butpyproject.tomldid not declarereportlab. A freshpip install -e '.[dev]'left the report generator broken withModuleNotFoundError: No module named 'reportlab'.Opposite-perspective review notes
I checked the tradeoff explicitly:
reportlabso the existing root-level report script imports and runs after normal project install.[reports]optional extra and lazy-import reportlab. That would reduce default install footprint, but it would still leave the current report script unavailable after the documented dev install unless users know to install an extra.Test Plan
pytest tests/test_generate_report.py -qfailed becausereportlabwas absent frompyproject.tomland unavailable in a fresh dev installpython -m pip install -e '.[dev]'pytest tests/test_generate_report.py -qpytest -qgenerate_report.build_report('/tmp/hae-report-probe.pdf')created a non-empty PDFgit diff --checkResult: 141 passed, 11 warnings (DSPy deprecation warnings only).
Partially addresses #33 (M4: reportlab missing dependency).