Skip to content

chore: name struct instead of using anonymous struct #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
secDre4mer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: name struct instead of using anonymous struct #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions thorlog/v3/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ type ProcessInfo struct {

Image *File `json:"image" textlog:"image,expand"`

ParentInfo struct {
Pid int32 `json:"pid" textlog:"ppid"`
Exe string `json:"exe" textlog:"parent"`
CommandLine string `json:"command" textlog:"parent_command"`
} `json:"parent_info,omitempty" textlog:",expand,omitempty"`
ParentInfo ParentProcessInfo `json:"parent_info,omitempty" textlog:",expand,omitempty"`
Copy link
Contributor

@gremat gremat Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't _info redundant in JSON? Or do you want to distinguish it from a nested (or linked) ProcessInfo struct for the parent?


ProcessTree StringList `json:"tree" textlog:"tree,omitempty" jsonschema:"nullable"`

Expand All @@ -49,6 +45,12 @@ type ProcessInfo struct {
Sections Sections `json:"sections,omitempty" textlog:"-"`
}

type ParentProcessInfo struct {
Pid int32 `json:"pid" textlog:"ppid"`
Exe string `json:"exe" textlog:"parent"`
CommandLine string `json:"command" textlog:"parent_command"`
Copy link
Contributor

@gremat gremat Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CommandLine is inconsistent with Cmdline from above.

}

type Sections []Section

// Section describes a memory range in a process's virtual memory.
Expand Down