chore: name struct instead of using anonymous struct #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gremat
requested changes
Jul 24, 2025
| type ParentProcessInfo struct { | ||
| Pid int32 `json:"pid" textlog:"ppid"` | ||
| Exe string `json:"exe" textlog:"parent"` | ||
| CommandLine string `json:"command" textlog:"parent_command"` |
Contributor
There was a problem hiding this comment.
CommandLine is inconsistent with Cmdline from above.
| Exe string `json:"exe" textlog:"parent"` | ||
| CommandLine string `json:"command" textlog:"parent_command"` | ||
| } `json:"parent_info,omitempty" textlog:",expand,omitempty"` | ||
| ParentInfo ParentProcessInfo `json:"parent_info,omitempty" textlog:",expand,omitempty"` |
Contributor
There was a problem hiding this comment.
Isn't _info redundant in JSON? Or do you want to distinguish it from a nested (or linked) ProcessInfo struct for the parent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.