chore(deps): bump actions/download-artifact from 4 to 5

.github/workflows/build.yml

@@ -273,7 +273,7 @@ jobs:
     steps:
       - name: Download NSIS installer
         id: download
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           pattern: 'nexo-engine-installer-msvc14-windows-latest'
 
@@ -345,7 +345,7 @@ jobs:
     steps:
       - name: Download DEB installer
         id: download
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           pattern: 'nexo-engine-installer-gcc13-ubuntu-latest'
 

editor/CMakeLists.txt

@@ -54,7 +54,6 @@ set(SRCS
         editor/src/DocumentWindows/AssetManager/Shutdown.cpp
         editor/src/DocumentWindows/AssetManager/Update.cpp
         editor/src/DocumentWindows/AssetManager/FolderTree.cpp
-        editor/src/DocumentWindows/AssetManager/Thumbnail.cpp
         editor/src/DocumentWindows/AssetManager/FileDrop.cpp
         editor/src/DocumentWindows/ConsoleWindow/Init.cpp
         editor/src/DocumentWindows/ConsoleWindow/Log.cpp

editor/main.cpp

@@ -26,7 +26,6 @@
 #include <loguru.hpp>
 #include <core/exceptions/Exceptions.hpp>
 
-#include "Path.hpp"
 #include "scripting/native/ManagedTypedef.hpp"
 #include "scripting/native/Scripting.hpp"
 

editor/src/ADocumentWindow.cpp

@@ -30,7 +30,7 @@ namespace nexo::editor {
         {
             const bool isDocked = currentWindow->DockIsActive;
             const ImGuiID currentDockID = currentWindow->DockId;
-            auto dockId = m_windowRegistry.getDockId(windowName);
+            const auto dockId = m_windowRegistry.getDockId(windowName);
 
             // If it's the first time opening the window and we have a dock id saved in the registry, then we force set it
             if (m_firstOpened && (dockId && currentDockID != *dockId))

editor/src/DockingRegistry.cpp

@@ -25,7 +25,7 @@ namespace nexo::editor {
 
 	std::optional<ImGuiID> DockingRegistry::getDockId(const std::string& name) const
 	{
-		auto it = dockIds.find(name);
+		const auto it = dockIds.find(name);
 		if (it != dockIds.end()) {
 			return it->second;
 		}
@@ -34,7 +34,7 @@ namespace nexo::editor {
 
 	void DockingRegistry::resetDockId(const std::string &name)
 	{
-        auto it = dockIds.find(name);
+        const auto it = dockIds.find(name);
         if (it == dockIds.end())
             return;
         dockIds.erase(it);

editor/src/DocumentWindows/AssetManager/AssetManagerWindow.hpp

@@ -67,15 +67,15 @@ namespace nexo::editor {
                 } color;
             };
 
-            std::set<int> m_selectedAssets;
+            std::set<unsigned int> m_selectedAssets;
             std::unordered_map<std::string, std::vector<std::string>, TransparentStringHash, std::equal_to<>> m_folderChildren;
             LayoutSettings m_layout;
 
             void calculateLayout(float availWidth);
             void drawMenuBar();
             void drawAssetsGrid();
-            void drawAsset(const assets::GenericAssetRef& asset, int index, const ImVec2& itemPos, const ImVec2& itemSize);
-            void handleSelection(int index, bool isSelected);
+            void drawAsset(const assets::GenericAssetRef& asset, unsigned int index, const ImVec2& itemPos, const ImVec2& itemSize);
+            void handleSelection(unsigned int index, bool isSelected);
 
             assets::AssetType m_selectedType = assets::AssetType::UNKNOWN;
             std::string m_currentFolder;  // Currently selected folder
@@ -87,13 +87,6 @@ namespace nexo::editor {
             void drawFolderTree();
             void drawFolderTreeItem(const std::string& name, const std::string& path);
 
-            void drawTextureThumbnail(
-                ImDrawList *drawList,
-                ImTextureID textureId,
-                const ImVec2 &itemPos,
-                const ImVec2& thumbnailEnd
-            ) const ;
-
             struct FolderCreationState {
                 bool isCreatingFolder = false;
                 char folderName[256] = "";
@@ -106,7 +99,7 @@ namespace nexo::editor {
             FolderCreationState m_folderCreationState;
             assets::AssetRef<assets::Texture> m_folderIcon;
 
-            ImTextureID getFolderIconTexture();
+            ImTextureID getFolderIconTexture() const;
 
             void handleNewFolderCreation();
             void drawFolder(
@@ -120,8 +113,8 @@ namespace nexo::editor {
             bool m_showDropIndicator = false;
 
             void handleDroppedFiles();
-            const assets::AssetLocation getAssetLocation(const std::filesystem::path &path) const;
-            void importDroppedFile(const std::string& filePath);
+            assets::AssetLocation getAssetLocation(const std::filesystem::path &path) const;
+            void importDroppedFile(const std::string& filePath) const;
     };
 
     /**

editor/src/DocumentWindows/AssetManager/FileDrop.cpp

@@ -13,40 +13,21 @@
 ///////////////////////////////////////////////////////////////////////////////
 
 #include "AssetManagerWindow.hpp"
-#include "assets/Asset.hpp"
 #include "assets/AssetImporter.hpp"
 #include "assets/AssetLocation.hpp"
-#include "assets/Assets/Model/Model.hpp"
-#include "assets/Assets/Texture/Texture.hpp"
 #include "Logger.hpp"
 #include <filesystem>
 #include <algorithm>
 
 namespace nexo::editor {
 
-    static assets::AssetType getAssetTypeFromExtension(const std::string &extension)
+    assets::AssetLocation AssetManagerWindow::getAssetLocation(const std::filesystem::path &path) const
     {
-        static const std::set<std::string> imageExtensions = {
-            ".png", ".jpg", ".jpeg", ".bmp", ".tga", ".gif", ".psd", ".hdr", ".pic", ".pnm", ".ppm", ".pgm"
-        };
-        if (imageExtensions.contains(extension))
-            return assets::AssetType::TEXTURE;
-        static const std::set<std::string> modelExtensions = {
-            ".gltf", ".glb", ".fbx", ".obj", ".dae", ".3ds", ".stl", ".ply", ".blend", ".x3d", ".ifc"
-        };
-        if (modelExtensions.contains(extension))
-            return assets::AssetType::MODEL;
-        return assets::AssetType::UNKNOWN;
-    }
-
-    const assets::AssetLocation AssetManagerWindow::getAssetLocation(const std::filesystem::path &path) const
-    {
-        std::string assetName = path.stem().string();
+        const std::string assetName = path.stem().string();
         std::filesystem::path folderPath;
-        std::string targetFolder = !m_hoveredFolder.empty() ? m_hoveredFolder : m_currentFolder;
+        const std::string targetFolder = !m_hoveredFolder.empty() ? m_hoveredFolder : m_currentFolder;
 
-        std::string assetPath = targetFolder;
-        std::string locationString = assetName + "@" + assetPath;
+        std::string locationString = assetName + "@" + targetFolder;
 
         LOG(NEXO_DEV,
             "Creating asset location: {} (current folder: '{}', hovered: '{}')",
@@ -78,31 +59,24 @@ namespace nexo::editor {
         buildFolderStructure();
     }
 
-    void AssetManagerWindow::importDroppedFile(const std::string& filePath)
+    void AssetManagerWindow::importDroppedFile(const std::string& filePath) const
     {
-        std::filesystem::path path(filePath);
+        const std::filesystem::path path(filePath);
 
         if (!std::filesystem::exists(path)) {
             LOG(NEXO_WARN, "Dropped file does not exist: {}", filePath);
             return;
         }
 
         std::string extension = path.extension().string();
-        std::transform(extension.begin(), extension.end(), extension.begin(), ::tolower);
-
-        assets::AssetType assetType = getAssetTypeFromExtension(extension);
-        if (assetType == assets::AssetType::UNKNOWN) {
-            LOG(NEXO_WARN, "Unsupported file type: {}", extension);
-            return;
-        }
+        std::ranges::transform(extension, extension.begin(), ::tolower);
 
-        assets::AssetLocation location = getAssetLocation(path);
+        const assets::AssetLocation location = getAssetLocation(path);
 
-        assets::AssetImporter importer;
         assets::ImporterFileInput fileInput{path};
         try {
-            auto assetRef = importer.importAssetAuto(location, fileInput);
-            if (!assetRef)
+            assets::AssetImporter importer;
+            if (const auto assetRef = importer.importAssetAuto(location, fileInput); !assetRef)
                 LOG(NEXO_ERROR, "Failed to import asset: {}", location.getPath().data());
         } catch (const std::exception& e) {
             LOG(NEXO_ERROR, "Exception while importing {}: {}", location.getPath().data(), e.what());

editor/src/DocumentWindows/AssetManager/FolderTree.cpp

@@ -59,8 +59,7 @@ namespace nexo::editor {
 
         if (opened) {
             // Use the precomputed children list
-            auto it = m_folderChildren.find(path);
-            if (it != m_folderChildren.end()) {
+            if (const auto it = m_folderChildren.find(path); it != m_folderChildren.end()) {
                 for (const auto& childPath : it->second) {
                     // Find the name of the child from m_folderStructure
                     std::string childName;
@@ -83,7 +82,7 @@ namespace nexo::editor {
             ImGui::OpenPopup("Create New Folder");
 
             // Center the popup
-            ImVec2 center = ImGui::GetMainViewport()->GetCenter();
+            const ImVec2 center = ImGui::GetMainViewport()->GetCenter();
             ImGui::SetNextWindowPos(center, ImGuiCond_Appearing, ImVec2(0.5f, 0.5f));
 
             if (ImGui::BeginPopupModal("Create New Folder", nullptr, ImGuiWindowFlags_AlwaysAutoResize)) {
@@ -102,7 +101,7 @@ namespace nexo::editor {
 
                         // Check if folder already exists
                         bool folderExists = false;
-                        for (const auto& [path, _] : m_folderStructure) {
+                        for (const auto &path: m_folderStructure | std::views::keys) {
                             if (path == newFolderPath) {
                                 folderExists = true;
                                 break;
@@ -164,20 +163,17 @@ namespace nexo::editor {
 
         std::unordered_set<std::string> seen{""};
 
-        const auto assets = assets::AssetCatalog::getInstance().getAssets();
-        for (auto& ref : assets) {
-            if (auto assetData = ref.lock()) {
+        for (const auto assets = assets::AssetCatalog::getInstance().getAssets(); auto& ref : assets) {
+            if (const auto assetData = ref.lock()) {
                 // normalized path: e.g. "Random/Sub"
                 std::filesystem::path p{ assetData->getMetadata().location.getPath() };
                 std::filesystem::path curr;
                 for (auto const& part : p) {
                     // skip empty or “_internal” style parts
-                    auto s = part.string();
-                    if (s.empty() || s.front() == '_')
+                    if (auto s = part.string(); s.empty() || s.front() == '_')
                         continue;
                     curr /= part;
-                    auto folderPath = curr.string();
-                    if (seen.emplace(folderPath).second) {
+                    if (auto folderPath = curr.string(); seen.emplace(folderPath).second) {
                         m_folderStructure.emplace_back(
                             folderPath,
                             curr.filename().string()
@@ -208,10 +204,7 @@ namespace nexo::editor {
 
         // favorites section
         {
-            ImGuiTreeNodeFlags headerFlags = ImGuiTreeNodeFlags_DefaultOpen | ImGuiTreeNodeFlags_OpenOnDoubleClick;
-            bool favoritesOpen = ImGui::TreeNodeEx(ICON_FA_STAR " Favorites", headerFlags);
-
-            if (favoritesOpen) {
+            if (ImGui::TreeNodeEx(ICON_FA_STAR " Favorites", ImGuiTreeNodeFlags_DefaultOpen | ImGuiTreeNodeFlags_OpenOnDoubleClick)) {
                 struct FavoriteItem {
                     std::string label;
                     assets::AssetType type;
@@ -224,7 +217,7 @@ namespace nexo::editor {
                 };
 
                 for (const auto& fav : favorites) {
-                    bool isSelected = (fav.type == m_selectedType);
+                    const bool isSelected = (fav.type == m_selectedType);
 
                     ImGuiTreeNodeFlags itemFlags = ImGuiTreeNodeFlags_Leaf | ImGuiTreeNodeFlags_NoTreePushOnOpen;
                     if (isSelected)