chore(deps): bump actions/download-artifact from 4 to 5 #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* **Style** * Improved type consistency by updating loop counters and variable types to use unsigned integers or size_t where appropriate. * Added [[maybe_unused]] attributes to suppress compiler warnings for unused variables and parameters. * **Refactor** * Simplified and clarified loops by removing unused variables and directly iterating over elements. * Removed unused variable assignments for cleaner and more maintainable code. * Enhanced raw component insertion logic to better handle non-trivially copyable types. * **Tests** * Updated test code to use explicit type casting and suppress unused variable warnings for improved clarity and compatibility.
… in insertRaw method
This pull request introduces a new "dark mode" feature for the windowing system and refactors related code for better maintainability. The most important changes include adding support for dark mode, updating window property management, and improving platform-specific functionality for Windows. ### Dark Mode Feature: * Added `setDarkMode` and `isDarkMode` methods to the `NxWindow` interface and implemented them in `NxOpenGlWindow`. These methods allow toggling and checking the dark mode state. [[1]](diffhunk://#diff-6aa9c7bed1966a4361e002990ab18ed46df76c9203947ef9585e89eeca4d3691R86-R92) [[2]](diffhunk://#diff-3c1a4fcd27d2d6aa984c17fab4ef191a059be8ae20a787e937b984721525f165R184-R222) [[3]](diffhunk://#diff-c46e4326747e212ca20ff622e20045b5ae5ceba80663c7d8e1306500cd568495R84-R89) * Updated `Application.cpp` to enable dark mode by default when initializing the window. ### Window Property Management: * Refactored `NxWindowProperty` to use `std::string` for the `title` field instead of a `const char*`, and added a new `isDarkMode` field. * Updated the constructor of `NxWindowProperty` to use `std::move` for the `title` parameter. ### Platform-Specific Improvements (Windows): * Added Windows-specific headers and logic to support immersive dark mode using `DwmSetWindowAttribute`. This includes error handling for cases where the window handle cannot be retrieved or the dark mode setting fails. [[1]](diffhunk://#diff-3c1a4fcd27d2d6aa984c17fab4ef191a059be8ae20a787e937b984721525f165R23-R30) [[2]](diffhunk://#diff-3c1a4fcd27d2d6aa984c17fab4ef191a059be8ae20a787e937b984721525f165R184-R222) ### Miscellaneous: * Updated `glfwCreateWindow` calls to use `std::string::c_str()` for compatibility with the updated `title` field. * **New Features** * Added support for enabling dark mode in application windows. * Enhanced window customization with the ability to set and retrieve the window title. * **Improvements** * Window properties now support string-based titles and a dark mode flag for greater flexibility.
…ch render passes draws onto it or use their own
…der target and grid does not copy the content anymore
…om mask pass and draws onto the same render target as forward and grid without copying
For a while now the render passes have broken some stuff, notably the selection. This was because of the copies we were doing between render passes, this was made at first because it could have been interesting to be able to see each render pass in the editor, but well render doc exists for that, and copying framebuffer is a pain in the ass. The copy was basically erasing the clear value of the color attachment where the entities id were stored for further sampling in the editor So now we are simply passing the same render target between render passes and drawing onto it <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Simplified render pass and pipeline management by removing internal framebuffer handling from most passes, centralizing render target management. * Updated API to use a single pipeline-wide render target instead of per-pass outputs. * Improved error handling with clearer exceptions if a render target is not set. * Streamlined and clarified internal logic for removing and executing render passes. * **Tests** * Updated tests to reflect new render target management and API changes. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
Author
|
A newer version of actions/download-artifact exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps actions/download-artifact from 4 to 5.
Release notes
Sourced from actions/download-artifact's releases.
... (truncated)
Commits
634f93cMerge pull request #416 from actions/single-artifact-id-download-pathb19ff43refactor: resolve download path correctly in artifact download tests (mainly ...e262cbebundle distbff23f9update docsfff8c14fix download path logic when downloading a single artifact by id448e3f8Merge pull request #407 from actions/nebuk89-patch-147225c4Update README.mdYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)