Revert "Update the OpenMcdf library in vbad project"#43
Merged
jozefizso merged 2 commits intoNetOfficeFw:mainfrom Jan 16, 2026
Merged
Revert "Update the OpenMcdf library in vbad project"#43jozefizso merged 2 commits intoNetOfficeFw:mainfrom
jozefizso merged 2 commits intoNetOfficeFw:mainfrom
Conversation
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In OpenMcdf 3.x,
CfbStreambuffers writes and defers updating the directory entry metadata until the stream is disposed/closed. This wasn't done and the produced compound files are corrupted - the stream/directory entries metadata are not updated and the entries appear to be empty although the data were written and the file has correct size. Reverting for now.Next steps: