Skip to content

Comments

Revert "Update the OpenMcdf library in vbad project"#43

Merged
jozefizso merged 2 commits intoNetOfficeFw:mainfrom
m-kovac:bugfix/revert-OpenMcdf-to-v2.4.1
Jan 16, 2026
Merged

Revert "Update the OpenMcdf library in vbad project"#43
jozefizso merged 2 commits intoNetOfficeFw:mainfrom
m-kovac:bugfix/revert-OpenMcdf-to-v2.4.1

Conversation

@m-kovac
Copy link
Contributor

@m-kovac m-kovac commented Jan 15, 2026

In OpenMcdf 3.x, CfbStream buffers writes and defers updating the directory entry metadata until the stream is disposed/closed. This wasn't done and the produced compound files are corrupted - the stream/directory entries metadata are not updated and the entries appear to be empty although the data were written and the file has correct size. Reverting for now.

Next steps:

  1. Round-trip tests that will compile and then decompile the compound file to check if the stream/directory entries correspond with the data written.
  2. Eventually update to OpenMcdf 3.x and update the code to explicitly dispose the streams.

@m-kovac m-kovac added the bug Something isn't working label Jan 15, 2026
@m-kovac m-kovac requested a review from jozefizso January 15, 2026 13:12
@jozefizso jozefizso requested a review from DominikPalo January 16, 2026 09:30
@jozefizso
Copy link
Member

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jozefizso jozefizso added this to the v2.0.1 milestone Jan 16, 2026
@jozefizso jozefizso merged commit 254e07c into NetOfficeFw:main Jan 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants