Add round-trip tests for testing compound file integrity#44
Merged
jozefizso merged 2 commits intoNetOfficeFw:mainfrom Jan 16, 2026
Conversation
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add tests that compile VBA projects and verify they can be decompiled. Catches compound file corruption where streams exist but directory entries have incorrect size/offset metadata, making the VBA code unreadable despite the file appearing valid.
jozefizso
force-pushed
the
feature/Add-round-trip-tests-for-compound-file-integrity
branch
from
a2f1fd6 to
5cee80d
Compare
jozefizso
reviewed
Jan 16, 2026
jozefizso
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests compile VBA projects and verify they can be decompiled. Catches compound file corruption where streams exist but directory entries have incorrect size/offset metadata, making the VBA code unreadable despite the file appearing valid.
Important:
these tests are based on
OpenMcdf v2.4.1and ideally merged after #43. When the package is updated abovev3, the tests must be updated with new API, but should catch the compound file corruption - the decompilation should not work.