Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
DOTNET_NOLOGO: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_GENERATE_ASPNET_CERTIFICATE: 0
BUILD_SIGN_RELEASE: '${{ vars.BUILD_SIGN_RELEASE }}'
ContinuousIntegrationBuild: true
RestoreLockedMode: true
RepositoryBranch: '${{ github.ref_name }}'
Expand Down Expand Up @@ -159,6 +160,7 @@ jobs:

- name: Archive code signing certificate
if: success() && matrix.configuration == 'Release'
id: certificate_artifact
uses: actions/upload-artifact@v6
with:
name: certificate
Expand All @@ -167,9 +169,12 @@ jobs:
- name: Release documentation
if: matrix.configuration == 'Release'
run: |
$certUrl = '${{ steps.certificate_artifact.outputs.artifact-url }}'
'To release the NuGet package, upload the signing certificate to NuGet Gallery via Account Settings: <https://www.nuget.org/account>. ' >> $env:GITHUB_STEP_SUMMARY
'See the `certificate` artifact for the signing certificate file.' >> $env:GITHUB_STEP_SUMMARY
'' >> $env:GITHUB_STEP_SUMMARY
'Download the [certiticate file]($certUrl).' >> $env:GITHUB_STEP_SUMMARY

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Interpolate certificate URL in release summary

In the Release documentation step, the line writing Download the [certiticate file]($certUrl). is wrapped in single quotes, so PowerShell does not expand $certUrl and the job summary always shows a literal $certUrl link instead of the artifact URL. This breaks the newly added guidance for release operators in Release runs, forcing them to manually locate the certificate artifact.

Useful? React with 👍 / 👎.

'' >> $env:GITHUB_STEP_SUMMARY
'Approve the `publish` job deployment to the `nuget-gallery` environment when the certificate was added to NuGet Gallery.' >> $env:GITHUB_STEP_SUMMARY

publish:
Expand Down
Loading