Use BUILD_SIGN_RELEASE env variable in release.yml workflow#461
Conversation
…e signing for build environment
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a15cf657cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'To release the NuGet package, upload the signing certificate to NuGet Gallery via Account Settings: <https://www.nuget.org/account>. ' >> $env:GITHUB_STEP_SUMMARY | ||
| 'See the `certificate` artifact for the signing certificate file.' >> $env:GITHUB_STEP_SUMMARY | ||
| '' >> $env:GITHUB_STEP_SUMMARY | ||
| 'Download the [certiticate file]($certUrl).' >> $env:GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
Interpolate certificate URL in release summary
In the Release documentation step, the line writing Download the [certiticate file]($certUrl). is wrapped in single quotes, so PowerShell does not expand $certUrl and the job summary always shows a literal $certUrl link instead of the artifact URL. This breaks the newly added guidance for release operators in Release runs, forcing them to manually locate the certificate artifact.
Useful? React with 👍 / 👎.
Fixes #460