Skip to content

[no-ci] fix(ci): prevent printf from treating error message as option #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwgk merged 2 commits into from
Mar 25, 2026
Merged

[no-ci] fix(ci): prevent printf from treating error message as option #1819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41cad4f
fix(ci): prevent printf from treating error message as option
rwgk Mar 25, 2026
11a7a29
fix(ci): allow CI/CD label to bypass module label requirement
rwgk Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/pr-metadata-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,12 @@ jobs:
ERRORS=""

# Module labels identify which package the PR touches.
# Cross-cutting labels exempt PRs from needing a module label.
MODULE_LABELS="cuda.bindings cuda.core cuda.pathfinder"
MODULE_EXEMPT_LABELS="CI/CD"
HAS_MODULE=false
for label in $LABEL_NAMES; do
for mod in $MODULE_LABELS; do
for mod in $MODULE_LABELS $MODULE_EXEMPT_LABELS; do
if [ "$label" = "$mod" ]; then
HAS_MODULE=true
break 2
Expand All @@ -50,7 +52,7 @@ jobs:
done

if [ "$HAS_MODULE" = "false" ]; then
ERRORS="${ERRORS}- **Missing module label**: add at least one of: \`cuda.bindings\`, \`cuda.core\`, \`cuda.pathfinder\`.\n"
ERRORS="${ERRORS}- **Missing module label**: add at least one of: \`cuda.bindings\`, \`cuda.core\`, \`cuda.pathfinder\` (or a cross-cutting label such as \`CI/CD\`).\n"
fi

# Type labels categorize the kind of change.
Expand Down Expand Up @@ -89,7 +91,7 @@ jobs:
{
echo "## PR Metadata Check Failed"
echo ""
printf "$ERRORS"
printf '%b' "$ERRORS"
echo ""
echo "Please update the PR at: $PR_URL"
} >> "$GITHUB_STEP_SUMMARY"
Expand Down
Loading