Skip to content

[no-ci] fix(ci): prevent printf from treating error message as option#1819

Merged
rwgk merged 2 commits intoNVIDIA:mainfrom
rwgk:fix_pr-metadata-check
Mar 25, 2026
Merged

[no-ci] fix(ci): prevent printf from treating error message as option#1819
rwgk merged 2 commits intoNVIDIA:mainfrom
rwgk:fix_pr-metadata-check

Conversation

@rwgk
Copy link
Copy Markdown
Collaborator

@rwgk rwgk commented Mar 25, 2026

Fixes printf: - : invalid option error in the PR metadata check workflow.

Error seen here:

Two fixes for the PR metadata check workflow.

Fix printf crashprintf "$ERRORS" fails when $ERRORS starts with a dash (e.g. - **Missing module label**...), because bash's printf interprets the leading - as an option flag. Fix: printf '%b' "$ERRORS" passes the variable as an argument rather than the format string, while %b still interprets \n escape sequences.

Allow CI/CD to bypass module label requirement — PRs that only touch CI/infrastructure don't belong to cuda.bindings, cuda.core, or cuda.pathfinder. The module label check now accepts CI/CD as a cross-cutting alternative, via a MODULE_EXEMPT_LABELS list that can be extended later if needed.

printf "$ERRORS" fails when $ERRORS starts with a dash. Use
printf '%b' "$ERRORS" so the variable is an argument, not the
format string.

Made-with: Cursor
@rwgk rwgk self-assigned this Mar 25, 2026
@rwgk rwgk added bug Something isn't working P0 High priority - Must do! github_actions Pull requests that update GitHub Actions code labels Mar 25, 2026
@rwgk rwgk changed the title [no ci] fix(ci): prevent printf from treating error message as option [no-ci] fix(ci): prevent printf from treating error message as option Mar 25, 2026
@rwgk rwgk added this to the ci backlog milestone Mar 25, 2026
@rwgk rwgk added cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do and removed P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module labels Mar 25, 2026
@rwgk
Copy link
Copy Markdown
Collaborator Author

rwgk commented Mar 25, 2026

/ok to test

@rwgk
Copy link
Copy Markdown
Collaborator Author

rwgk commented Mar 25, 2026

close / re-open

@rwgk rwgk closed this Mar 25, 2026
@rwgk rwgk reopened this Mar 25, 2026
@rwgk rwgk enabled auto-merge (squash) March 25, 2026 04:24
@rwgk rwgk requested review from leofang and rparolin March 25, 2026 04:24
@rwgk rwgk added CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module and removed github_actions Pull requests that update GitHub Actions code cuda.bindings Everything related to the cuda.bindings module labels Mar 25, 2026
Cross-cutting PRs that only touch CI/infrastructure don't belong
to a specific module. Accept CI/CD as an alternative to the
cuda.bindings/cuda.core/cuda.pathfinder module labels.

Made-with: Cursor
@rwgk rwgk merged commit 079f937 into NVIDIA:main Mar 25, 2026
15 checks passed
@github-actions
Copy link
Copy Markdown

Doc Preview CI
Preview removed because the pull request was closed or merged.

@rwgk rwgk deleted the fix_pr-metadata-check branch March 25, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants