Clean up nemo-retriever dependencies#2183
Draft
colesmcintosh wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Cole McIntosh <colemcintosh6@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nemo_retrievercode to the core project dependenciestestextra for MoviePy while constraining it to the Pillow-compatible 1.x linenemo_retriever/uv.lockCloses #1392.
Notes
api/pyproject.toml; on currentmain, the relevant manifest isnemo_retriever/pyproject.toml.opencv-python-headlessrather thanopencv-pythonbecause this project already suppressesopencv-pythonin uv overrides to avoidcv2directory conflicts.redis,python-docx,python-pptx,minio, andpymilvus, are not imported by the current tree and were not added as unused runtime dependencies.Validation
python -c "import pathlib,tomllib; tomllib.loads(pathlib.Path('nemo_retriever/pyproject.toml').read_text()); print('pyproject ok')"uvx --from uv uv lock --check --quietfromnemo_retriever/git diff --checkNot Run
python -m pytest nemo_retriever/tests/test_nemotron_ocr_v2_nightly.py::test_local_extra_accepts_stable_ocr_2_and_newer_dev_releasescould not start in the ambient Python because project dependencies such aspandasare not installed there.