-
Notifications
You must be signed in to change notification settings - Fork 498
Forward-merge release/1.4 into develop #1545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…1535) Extended nightly run incorrectly tested for huggingface support. Fix this by directly attempting to import torch Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Tests** * Simplified dependency handling by removing module-level import guards and using runtime checks that skip tests when optional ML libraries are unavailable. * Deferred importing of optional config/components until after runtime checks to prevent import errors and maintain consistent test behavior when dependencies are present. Authors: - Will Killian (https://github.com/willkill07) Approvers: - https://github.com/mnajafian-nv URL: #1535
|
FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1545 +/- ##
========================================
Coverage 75.00% 75.00%
========================================
Files 553 553
Lines 38914 38914
========================================
Hits 29186 29186
Misses 9728 9728
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
## Description Updating the Readme with the latest features and focus. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated README: refreshed hero text, reorganized features into a "Building Agents" section (framework-agnostic, reusability, customization, UI, profiling, observability, evaluation, hyper-parameter/prompt optimizer, RL fine-tuning, protocol support). * New Features list revised to include LangGraph agent wrapper, Automatic RL, NVIDIA Dynamo integration, A2A support, Safety & Security engine, and Bedrock/Strands updates. * Roadmap, installation wording, evaluation/finetuning headings, supported frameworks table, and optimizer docs reformatted. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Michael Demoret <mdemoret@nvidia.com> Signed-off-by: mnajafian-nv <mnajafian@nvidia.com> Co-authored-by: mnajafian-nv <mnajafian@nvidia.com>
## Description - Adds 1.4 Changelog - Updates release notes for 1.4 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Release notes added for v1.4.0 (2026-02-02) outlining notable features and improvements: A2A support, Amazon Bedrock AgentCore & Strands, LangChain/LangGraph automatic agent wrapper, Microsoft AutoGen, initial NVIDIA Dynamo integration, and per-user functions with deferred instantiation and per-user state. * Release header bumped to 1.4.0; sections added for Notable Features, Breaking Changes, New Features, Improvements, Bug Fixes, Documentation Updates, and New Contributors. * Known Issues preserved; minor README wording tweak for protocol support. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Will Killian <wkillian@nvidia.com> Co-authored-by: mnajafian-nv <mnajafian@nvidia.com>
mnajafian-nv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## Description Closes #1545 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Published Release 1.4.0 notes with comprehensive feature and improvement documentation * Updated product positioning to emphasize AI agent intelligence, observability, and continuous learning * Reorganized documentation structure to highlight agent frameworks, optimization capabilities, and security features * Updated roadmap with KV-Cache optimization and memory enhancements <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Forward-merge triggered by push to release/1.4 that creates a PR to keep develop up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.