-
Notifications
You must be signed in to change notification settings - Fork 498
Forward-merge release/1.4 into develop #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward-merge release/1.4 into develop #1552
Conversation
…VIDIA#1535) Extended nightly run incorrectly tested for huggingface support. Fix this by directly attempting to import torch Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Tests** * Simplified dependency handling by removing module-level import guards and using runtime checks that skip tests when optional ML libraries are unavailable. * Deferred importing of optional config/components until after runtime checks to prevent import errors and maintain consistent test behavior when dependencies are present. Authors: - Will Killian (https://github.com/willkill07) Approvers: - https://github.com/mnajafian-nv URL: NVIDIA#1535
## Description Updating the Readme with the latest features and focus. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated README: refreshed hero text, reorganized features into a "Building Agents" section (framework-agnostic, reusability, customization, UI, profiling, observability, evaluation, hyper-parameter/prompt optimizer, RL fine-tuning, protocol support). * New Features list revised to include LangGraph agent wrapper, Automatic RL, NVIDIA Dynamo integration, A2A support, Safety & Security engine, and Bedrock/Strands updates. * Roadmap, installation wording, evaluation/finetuning headings, supported frameworks table, and optimizer docs reformatted. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Michael Demoret <mdemoret@nvidia.com> Signed-off-by: mnajafian-nv <mnajafian@nvidia.com> Co-authored-by: mnajafian-nv <mnajafian@nvidia.com>
## Description - Adds 1.4 Changelog - Updates release notes for 1.4 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Release notes added for v1.4.0 (2026-02-02) outlining notable features and improvements: A2A support, Amazon Bedrock AgentCore & Strands, LangChain/LangGraph automatic agent wrapper, Microsoft AutoGen, initial NVIDIA Dynamo integration, and per-user functions with deferred instantiation and per-user state. * Release header bumped to 1.4.0; sections added for Notable Features, Breaking Changes, New Features, Improvements, Bug Fixes, Documentation Updates, and New Contributors. * Known Issues preserved; minor README wording tweak for protocol support. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Will Killian <wkillian@nvidia.com> Co-authored-by: mnajafian-nv <mnajafian@nvidia.com>
WalkthroughForward-merge of release/1.4 branch into develop, updating documentation for the 1.4.0 release. Changes include new changelog entries, restructured README with updated feature descriptions and roadmap, and refined titles across multiple documentation guides. No code or API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mnajafian-nv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/nvidia_nat_langchain/tests/test_langchain_agents.py (1)
26-27:⚠️ Potential issue | 🟡 MinorRemove the global
HuggingFaceConfigimport to avoid redefinition and unguarded optional deps.The local import is correctly guarded by the optional-dependency check, but the top-level import now triggers Ruff F811 and defeats the purpose of lazy imports. Drop the module-level import.
🔧 Proposed fix
-from nat.llm.huggingface_llm import HuggingFaceConfigAlso applies to: 157-157
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Around line 54-60: Update the CHANGELOG bullets that use the acronym "NAT" so
they either spell out "NeMo Agent Toolkit" or wrap code identifiers in
backticks; specifically replace "NAT A2A Client & Server Support" (and any other
bullets containing "NAT" such as the bridge/implementation bullets) with "NeMo
Agent Toolkit A2A Client & Server Support" or use backticks for code identifiers
like `NAT` and ensure "a2a" references are consistently formatted as either
spelled out or backticked (e.g., `A2A`) to comply with the Markdown
documentation guideline.
In `@docs/source/improve-workflows/optimizer.md`:
- Around line 344-350: Remove the leftover Git conflict markers (<<<<<<<,
=======, >>>>>>>) in the two prompt entries and keep the intended module path
`~nat.agent.prompt_optimizer.register`; specifically update the
`prompt.prompt_population_init_function` and
`prompt.prompt_recombination_function` lines to a single, clean pair of bullets
using `~nat.agent.prompt_optimizer.register` (no conflict markers), and ensure
the text follows the doc style guidelines (use "NeMo Agent Toolkit" for
titles/pages and "NeMo Agent Toolkit" or "the toolkit" elsewhere as
appropriate).
In `@README.md`:
- Around line 68-71: The README uses an inanimate possessive in the "Agent
Optimization" section ("Improve your agent's quality, accuracy, and
performance"); update that sentence to remove the "'s" (e.g., change to "Improve
agent quality, accuracy, and performance" or "Improve the quality, accuracy, and
performance of your agent") so the header/intro line in the "Agent Optimization"
block is non-possessive while leaving the linked bullet items (Evaluation
System, Hyper-Parameter and Prompt Optimizer, Fine-tuning with Reinforcement
Learning) unchanged.
- Around line 44-45: Change the inanimate possessive "agent’s workflows" in the
README sentence under "[**Automatic Reinforcement Learning (RL):**]" to a
non-possessive form such as "agent workflows" or "workflows of the agent"; edit
the phrase inside the sentence that currently reads "fine-tuning open LLMs to
better understand your agent's workflows, tools, and prompts" so it reads e.g.
"fine-tuning open LLMs to better understand your agent workflows, tools, and
prompts" (or use "workflows of the agent") to comply with the Markdown
documentation guideline.
- Around line 61-63: Update the sentence in the "Framework Agnostic" bullet that
currently reads "Use the toolkit with popular frameworks..." to use a
capitalized product name—replace it with "Use the Toolkit with popular
frameworks..." or "Use NeMo Agent Toolkit with popular frameworks..."; locate
the exact string "Use the toolkit with popular frameworks such as ..." in the
README.md and make the capitalization change there so documentation uses
"Toolkit" consistently.
Signed-off-by: Will Killian <wkillian@nvidia.com>
dbeec88 to
56c4f66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/source/release-notes.md`:
- Line 26: The phrase "your agent's workflows, tools, and prompts" in the
release notes uses an inanimate possessive; update that sentence to avoid "'s"
by replacing that fragment with "agent workflows, tools, and prompts" (or
"workflows of your agent, tools, and prompts") so the line reads with the
non-possessive form while preserving the rest of the sentence and links.
|
/merge nosquash |
|
Could not determine original ForwardMerger PR from branch name. The branch name should follow the pattern |
Description
Closes #1545
By Submitting this PR I confirm:
Summary by CodeRabbit