Skip to content

[DEV] Minor update optimizer #4082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FDecaYed merged 2 commits into from
Apr 7, 2026
Merged

[DEV] Minor update optimizer #4082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2733a14
remove out of date assert
skyw Mar 31, 2026
3fa4966
add safe global for torch ckpt
skyw Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions megatron/core/safe_globals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
RerunState,
BytesIO,
Signals,
torch._C.Generator, # Needed for torch format ckpt loading after weights_only default change
]


Expand Down
4 changes: 0 additions & 4 deletions megatron/training/arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1483,10 +1483,6 @@ def validate_args(args, defaults={}):
args.use_layer_wise_distributed_optimizer = True
args.use_distributed_optimizer = False

if args.optimizer == 'muon':
assert not args.overlap_grad_reduce, "Muon optimizer does not support overlap grad reduce. Use dist_muon instead."
assert not args.overlap_param_gather, "Muon optimizer does not support overlap param gather. Use dist_muon instead."

assert not args.use_distributed_optimizer, "Muon optimizer does not support distributed optimizer for now."
assert not args.use_torch_fsdp2, "Muon optimizer does not support Torch-FSDP2 for now."
assert not args.use_megatron_fsdp, "Muon optimizer does not support Megatron-FSDP for now."
Expand Down
Loading