Skip to content

[DEV] Minor update optimizer#4082

Open
skyw wants to merge 2 commits intoNVIDIA:devfrom
skyw:minor_update_optimizer
Open

[DEV] Minor update optimizer#4082
skyw wants to merge 2 commits intoNVIDIA:devfrom
skyw:minor_update_optimizer

Conversation

@skyw
Copy link
Copy Markdown
Contributor

@skyw skyw commented Mar 31, 2026

What does this PR do ?

Remove out of date assert.
Add safe global for torch format ckpt loading after weight_only defaults change on torch.load

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

skyw added 2 commits March 31, 2026 10:11
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw skyw requested review from a team as code owners March 31, 2026 17:25
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 31, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@skyw skyw requested a review from FDecaYed March 31, 2026 17:25
@skyw skyw changed the title Minor update optimizer [DEV] Minor update optimizer Mar 31, 2026
@skyw
Copy link
Copy Markdown
Contributor Author

skyw commented Mar 31, 2026

/ok to test 3fa4966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants