CCM-9305 child letter template, letter font change, email address & style fixes#102
Merged
jakecosgrove merged 2 commits intomainfrom Apr 17, 2025
Merged
Conversation
jakecosgrove
approved these changes
Apr 17, 2025
Contributor
jakecosgrove
left a comment
There was a problem hiding this comment.
All looks good, well done! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
/using-nhs-notify/letter-templates changes:
-added 'mm' to first measurement in '(210 x 297mm)' (style fix)
Other changes:
Context
Change to parent or guardian letter (also known as child letter) requested by Romy and Alex N as part of CCM-9305. The extra line in the address block still fits within the address window of the overlay.
The fix to the letter templates' fonts (Noto Sans Medium to Noto Sans) was just something I spotted and wanted to rectify while doing this PR.
The email address change was requested by Amina. Amina clarified that 'england.nhsnotify@nhs.net is only for expression of interest and wider enquiries. Then england.nhsnotifyonboarding@nhs.net is for the onboarding stuff so anything under 'using nhs notify'.
I spotted the /nhs-app-templates email typo on a call with Alex earlier and wanted to fix.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.