Skip to content

CCM-14410: Make the eventpub lambda handle unknown plane values #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gareth-allan merged 1 commit into from
Mar 2, 2026
Merged

CCM-14410: Make the eventpub lambda handle unknown plane values #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions infrastructure/terraform/modules/eventpub/lambda/eventpub/src/__tests__/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,19 @@ describe('SNS to EventBridge Lambda', () => {
expect(sqsMock.calls()).toHaveLength(1);
});

test('Event with unknown plane field is sent to DLQ', async () => {
const eventUnknownPlane = { ...validCloudEvent, plane: "unknown" };

const snsEventUnknownPlane = {
Records: [
{ Sns: { Message: JSON.stringify(eventUnknownPlane) } }
]
};

await handler(snsEventUnknownPlane);

expect(sqsMock.calls()).toHaveLength(1);
});

test('Retries on EventBridge failure and sends failed events to DLQ', async () => {
eventBridgeMock
Expand Down
5 changes: 3 additions & 2 deletions infrastructure/terraform/modules/eventpub/lambda/eventpub/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,12 @@ exports.handler = async (snsEvent) => {

const dataEvents = validEvents.filter(event => event.plane === 'data');
const controlEvents = validEvents.filter(event => event.plane === 'control');
const unknownEvents = validEvents.filter(event => event.plane !== 'data' && event.plane !== 'control');

console.debug(`Data events: ${dataEvents.length}, Control events: ${controlEvents.length}`);
console.debug(`Data events: ${dataEvents.length}, Control events: ${controlEvents.length}, Unknown events: ${unknownEvents.length}`);

const failedDataEvents = await sendToEventBridge(dataEvents, DATA_PLANE_EVENT_BUS_ARN);
const failedControlEvents = await sendToEventBridge(controlEvents, CONTROL_PLANE_EVENT_BUS_ARN);

await sendToDLQ([...failedDataEvents, ...failedControlEvents]);
await sendToDLQ([...failedDataEvents, ...failedControlEvents, ...unknownEvents]);
};